Install platform apps into a separate data directory

chrome/app/chrome_main_app_mode_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // On Mac, one can't make shortcuts with command-line arguments. Instead, we
 // produce small app bundles which locate the Chromium framework and load it,
 // passing the appropriate data. This is the entry point into the framework for
 // those app bundles.
 
 #include <string>  // TODO(viettrungluu): only needed for temporary hack
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths_internal.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/mac/app_mode_common.h"
 
 extern "C" {
 
 // |ChromeAppModeStart()| is the point of entry into the framework from the app
 // mode loader.
 __attribute__((visibility("default")))
 int ChromeAppModeStart(const app_mode::ChromeAppModeInfo* info);
 
 // TODO(viettrungluu): put this in a header file somewhere.
@@ skipping 13 matching lines @@
 
   RAW_CHECK(!info->chrome_versioned_path.empty());
   FilePath* chrome_versioned_path = new FilePath(info->chrome_versioned_path);
   RAW_CHECK(!chrome_versioned_path->empty());
   chrome::SetOverrideVersionedDirectory(chrome_versioned_path);
 
   base::mac::SetOverrideOuterBundlePath(info->chrome_outer_bundle_path);
   base::mac::SetOverrideFrameworkBundlePath(
       chrome_versioned_path->Append(chrome::kFrameworkName));
 
-  // TODO(viettrungluu): do something intelligent with data

[Mihai Parparita -not on Chrome, 2012/02/21 20:41:02]

So we're blessing this hack? It seems like we'd want to use the constant names
for the flags, and possibly CommandLine::Init, AppendSwitch, etc.

[sail, 2012/02/22 23:35:33]

Done.

-  //  return ChromeMain(info->argc, info->argv);
-  // For now, a cheesy hack instead.
   RAW_CHECK(info->app_mode_id.size());
-  std::string argv1(std::string("--app-id=") + info->app_mode_id);
-  std::string argv2(
-      std::string("--user-data-dir=") + info->user_data_dir.value());
+  std::string argv1("--app-id=" + info->app_mode_id);
+  std::string argv2("--user-data-dir=" + info->user_data_dir.value());
+  std::string argv3("--load-extension=" + info->extension_path.value());

[Mihai Parparita -not on Chrome, 2012/02/21 20:41:02]

Add a TODO about switching to a different flag that doesn't imply Location::LOAD
for the extension

[sail, 2012/02/22 23:35:33]

Done.

   char* argv[] = { info->argv[0],
                    const_cast<char*>(argv1.c_str()),
-                   const_cast<char*>(argv2.c_str()) };
+                   const_cast<char*>(argv2.c_str()),
+                   const_cast<char*>(argv3.c_str()) };
   return ChromeMain(static_cast<int>(arraysize(argv)), argv);
 }