Allow dbus clients to silence logging when a service is unavailable.

dbus/object_proxy.h

Index: dbus/object_proxy.h
diff --git a/dbus/object_proxy.h b/dbus/object_proxy.h
index ef453054915786accb66d82268a22506b6a69240..5f4887e17de233aa7ae65a6d4440f158b8e4604e 100644
--- a/dbus/object_proxy.h
+++ b/dbus/object_proxy.h
@@ -30,11 +30,21 @@ class Signal;
 // object is is alive when callbacks referencing |this| are called.
 class ObjectProxy : public base::RefCountedThreadSafe<ObjectProxy> {
  public:
+  // Clients should decide whether the service pointed to by this
+  // proxy must be available for proper operation. If not, they should
+  // pass IGNORE_SERVICE_UNKNOWN_ERRORS to silence logging of
+  // org.freedesktop.DBus.Error.ServiceUnknown errors.
+  enum ServiceUnknownBehavior {
+    LOG_SERVICE_UNKNOWN_ERRORS,
+    IGNORE_SERVICE_UNKNOWN_ERRORS

[satorux1, 2012/02/10 08:12:52]

Let's make this more generic like

// OR-ed options.
enum ObjectProxyOptions {
  NONE = 0,
  IGNORE_SERVICE_UNKNOWN_ERRORS = 1 << 0,
  // The options are OR-ed so the next option value should be 1 << 1
}

[satorux1, 2012/02/10 08:15:13]

Since it's inside ObjectProxy class, just 'Options' should suffice.

[adamk, 2012/02/10 17:57:16]

Done.

[adamk, 2012/02/10 17:57:16]

Done.

+  };
+
   // Client code should use Bus::GetObjectProxy() instead of this
   // constructor.
   ObjectProxy(Bus* bus,
               const std::string& service_name,
-              const std::string& object_path);
+              const std::string& object_path,
+              ServiceUnknownBehavior service_unknown_behavior);

[satorux1, 2012/02/10 08:12:52]

And make it 'int'

[adamk, 2012/02/10 17:57:16]

Done.

 
   // Special timeout constants.
   //
@@ -194,6 +204,8 @@ class ObjectProxy : public base::RefCountedThreadSafe<ObjectProxy> {
 
   std::set<std::string> match_rules_;
 
+  const bool log_unknown_service_errors_;
+
   DISALLOW_COPY_AND_ASSIGN(ObjectProxy);
 };