Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 9372126: Set minimize property and re-enable tests on Aura (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tabs_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_aura.cc
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index 098eeaed904ba314b516efa0355ac5cc8ee5e6b7..4e94a2314a84e584d07807a2ad73cd2c83da2170 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -415,6 +415,8 @@ gfx::Rect NativeWidgetAura::GetRestoredBounds() const {
}
void NativeWidgetAura::SetBounds(const gfx::Rect& bounds) {
+ if (GetRestoreBounds(window_))
Ben Goodger (Google) 2012/02/23 18:27:37 Why is this conditional on restore bounds already
stevenjb 2012/02/23 18:41:02 I didn't want to change the behavior if kRestoreBo
oshima 2012/02/23 18:46:20 If window is in normal state, there is nothing to
stevenjb 2012/02/23 18:54:23 Actually, I was wrong, I was looking at the wrong
oshima 2012/02/24 00:29:39 Restore bounds make sense only when the window is
+ SetRestoreBounds(window_, bounds);
window_->SetBounds(bounds);
}
@@ -516,8 +518,9 @@ void NativeWidgetAura::Maximize() {
}
void NativeWidgetAura::Minimize() {
- // No minimized window for aura. crbug.com/104571.
- NOTREACHED();
+ // Note: This currently does not do anything except set the property,
+ // see crbug.com/104571.
+ window_->SetProperty(aura::client::kShowStateKey, ui::SHOW_STATE_MINIMIZED);
}
bool NativeWidgetAura::IsMaximized() const {
« no previous file with comments | « chrome/browser/extensions/extension_tabs_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698