Polished on side-loaded extension install alert.

chrome/browser/extensions/extension_global_error.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_global_error.h"
 
 #include "base/logging.h"
 #include "base/string16.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 68 matching lines @@
     message += l10n_util::GetStringFUTF16(template_message_id,
                                           string16(ASCIIToUTF16(e->name())));
   }
   return message;
 }
 
 string16 ExtensionGlobalError::GenerateMessage() {
   return GenerateMessageSection(external_extension_ids_.get(),
                                 IDS_EXTENSION_ALERT_ITEM_EXTERNAL) +
          GenerateMessageSection(blacklisted_extension_ids_.get(),
-                                IDS_EXTENSION_ALERT_ITEM_EXTERNAL) +
+                                IDS_EXTENSION_ALERT_ITEM_BLACKLISTED) +
          GenerateMessageSection(orphaned_extension_ids_.get(),
-                                IDS_EXTENSION_ALERT_ITEM_EXTERNAL);
+                                IDS_EXTENSION_ALERT_ITEM_ORPHANED);
 }
 
 string16 ExtensionGlobalError::GetBubbleViewMessage() {
   if (message_.empty()) {
     message_ = GenerateMessage();
+    if (message_[message_.size()-1] == '\n')
+      message_.resize(message_.size()-1);

[Evan Stade, 2012/03/19 21:45:56]

spaces around operators.

[Aaron Boodman, 2012/03/19 22:00:07]

Dang, how did I miss this... Thanks Evan.

[chebert, 2012/03/26 22:22:24]

Done.

   }
   return message_;
 }
 
 string16 ExtensionGlobalError::GetBubbleViewAcceptButtonLabel() {
   return l10n_util::GetStringUTF16(IDS_EXTENSION_ALERT_ITEM_OK);
 }
 
 string16 ExtensionGlobalError::GetBubbleViewCancelButtonLabel() {
   return l10n_util::GetStringUTF16(IDS_EXTENSION_ALERT_ITEM_DETAILS);
 }
 
 void ExtensionGlobalError::OnBubbleViewDidClose(Browser* browser) {
   extension_service_->HandleExtensionAlertClosed();
 }
 
 void ExtensionGlobalError::BubbleViewAcceptButtonPressed(Browser* browser) {
   extension_service_->HandleExtensionAlertAccept();
 }
 
 void ExtensionGlobalError::BubbleViewCancelButtonPressed(Browser* browser) {
   extension_service_->HandleExtensionAlertDetails(browser);
 }