Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 9372065: Update clients to use new TestServer constructor. (Closed)

Created:
8 years, 10 months ago by erikwright (departed)
Modified:
8 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, kkania, creis+watch_chromium.org, akalin, ncarter (slow), tburkard+watch_chromium.org, Raghu Simha, brettw-cc_chromium.org, ajwong+watch_chromium.org, mihaip+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, darin-cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr., Avi (use Gerrit), robertshield, mmenke
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update clients to use new TestServer constructor. BUG=114369 TEST=tests all pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123572

Patch Set 1 #

Patch Set 2 : Fix merge and style errors. #

Patch Set 3 : Fix an additional client. #

Patch Set 4 : Fix a compilation failure. #

Patch Set 5 : More template fixes. #

Patch Set 6 : Speculative fix for the pyauto wrapper. #

Patch Set 7 : Remove files that were reviewed and committed separately. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -14 lines) Patch
M chrome/browser/collected_cookies_uitest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/custom_handlers/custom_handlers_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/infobars/infobars_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/notifications_interactive_uitest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 6 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/repost_form_warning_uitest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/session_history_uitest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_restore_uitest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/external_extension_uitest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/loadtimes_extension_bindings_uitest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/perf/mach_ports_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 3 4 5 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M net/tools/testserver/run_testserver.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
erikwright (departed)
I plan to break this into smaller CLs for the purposes of committing, to (1) ...
8 years, 10 months ago (2012-02-22 11:31:20 UTC) #1
Paweł Hajdan Jr.
Rubber-stamp LGTM.
8 years, 10 months ago (2012-02-22 14:40:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/9372065/8001
8 years, 10 months ago (2012-02-24 15:49:59 UTC) #3
commit-bot: I haz the power
Try job failure for 9372065-8001 (retry) on win_rel for step "unit_tests". It's a second try, ...
8 years, 10 months ago (2012-02-24 19:43:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/9372065/8001
8 years, 10 months ago (2012-02-24 19:47:49 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-24 23:05:33 UTC) #6
Change committed as 123572

Powered by Google App Engine
This is Rietveld 408576698