webkit/fileapi/file_system_dir_url_request_job.h - Issue 9372044: Refactor FileSystemOperation to take callback for each method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/file_system_dir_url_request_job.h

Issue 9372044: Refactor FileSystemOperation to take callback for each method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reflected kinuko's comments + Fixture for failing-Write -> Cancel pattern. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/fileapi/file_system_dir_url_request_job.h

diff --git a/webkit/fileapi/file_system_dir_url_request_job.h b/webkit/fileapi/file_system_dir_url_request_job.h

index 1e7179b59435fdb1a91b5eadebea90c822a31951..fd95130da9b430cafe21153f7b403f8b6bfbca0d 100644

--- a/webkit/fileapi/file_system_dir_url_request_job.h

+++ b/webkit/fileapi/file_system_dir_url_request_job.h

@@ -47,7 +47,8 @@ class FileSystemDirURLRequestJob : public net::URLRequestJob {

virtual ~FileSystemDirURLRequestJob();

void StartAsync();

- void DidReadDirectory(const std::vector<base::FileUtilProxy::Entry>& entries,

+ void DidReadDirectory(base::PlatformFileError result,

+ const std::vector<base::FileUtilProxy::Entry>& entries,

bool has_more);

FileSystemOperationInterface* GetNewOperation(const GURL& url);