ui/gfx/compositor/layer_animator.cc - Issue 9371007: Fix a memory leak in the layer animator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/compositor/layer_animator.cc

Issue 9371007: Fix a memory leak in the layer animator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove valgrind suppression Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/compositor/layer_animator.cc

diff --git a/ui/gfx/compositor/layer_animator.cc b/ui/gfx/compositor/layer_animator.cc

index f98904cfd22c99c710f45b573da2cccc1e220266..cc10f04ff949cafd6b78bdd3915ceac290ebff5b 100644

--- a/ui/gfx/compositor/layer_animator.cc

+++ b/ui/gfx/compositor/layer_animator.cc

@@ -396,6 +396,8 @@ void LayerAnimator::ImmediatelySetNewTarget(LayerAnimationSequence* sequence) {

const bool abort = false;

RemoveAllAnimationsWithACommonProperty(sequence, abort);

scoped_ptr<LayerAnimationSequence> removed(RemoveAnimation(sequence));

+ if (!removed.get())

+ removed.reset(sequence);

sky 2012/02/09 03:48:56 Add a comment here.

sequence->Progress(sequence->duration(), delegate());

}