Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9371005: GTK: Do more GSEALing. (Closed)

Created:
8 years, 10 months ago by Elliot Glaysher
Modified:
8 years, 10 months ago
Reviewers:
James Hawkins, sky
CC:
chromium-reviews
Visibility:
Public.

Description

GTK: Do more GSEALing. BUG=79722 R=jhawkins TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -28 lines) Patch
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 7 chunks +20 lines, -13 lines 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.cc View 6 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/slide_animator_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/status_bubble_gtk.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/gfx/gtk_preserve_window.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
8 years, 10 months ago (2012-02-09 01:08:10 UTC) #1
James Hawkins
lgtm
8 years, 10 months ago (2012-02-09 01:09:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9371005/1
8 years, 10 months ago (2012-02-09 01:11:50 UTC) #3
commit-bot: I haz the power
Presubmit check for 9371005-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 10 months ago (2012-02-09 01:11:54 UTC) #4
Elliot Glaysher
Adding sky to the TBR line for the few line change in a gtk file ...
8 years, 10 months ago (2012-02-09 20:11:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9371005/1
8 years, 10 months ago (2012-02-09 20:11:37 UTC) #6
commit-bot: I haz the power
8 years, 10 months ago (2012-02-09 21:43:56 UTC) #7 
Change committed as 121304

Powered by Google App Engine
This is Rietveld 408576698