Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1810)

Unified Diff: chrome/common/extensions/url_pattern.cc

Issue 9370043: Add default intents methods for web data service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix up tests for new URLPattern reuse. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/webdata/web_intents_table_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/url_pattern.cc
diff --git a/chrome/common/extensions/url_pattern.cc b/chrome/common/extensions/url_pattern.cc
index c72f98cfea037dea5dc91f42eb2039577d86e76a..6f89a0386715e6bdfad7f8632dca5a6e16575ceb 100644
--- a/chrome/common/extensions/url_pattern.cc
+++ b/chrome/common/extensions/url_pattern.cc
@@ -130,6 +130,9 @@ bool URLPattern::operator==(const URLPattern& other) const {
URLPattern::ParseResult URLPattern::Parse(const std::string& pattern) {
spec_.clear();
+ SetMatchAllURLs(false);
+ SetMatchSubdomains(false);
+ SetPort("*");
groby-ooo-7-16 2012/02/14 00:14:30 Why are we setting those here? Isn't that covered
Greg Billock 2012/02/14 01:21:46 This is actually in another CL that has gone in al
// Special case pattern to match every valid URL.
if (pattern == kAllUrlsPattern) {
« no previous file with comments | « chrome/browser/webdata/web_intents_table_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698