Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Unified Diff: chrome/browser/renderer_host/chrome_render_view_host_observer.cc

Issue 9370013: Simplify the handling of crashed extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/chrome_render_view_host_observer.cc
diff --git a/chrome/browser/renderer_host/chrome_render_view_host_observer.cc b/chrome/browser/renderer_host/chrome_render_view_host_observer.cc
index 46183467fca2daaace4501cfc38c2c20bcddead3..0fe39d50e6496957e6572f69a6e373b3ff429eb0 100644
--- a/chrome/browser/renderer_host/chrome_render_view_host_observer.cc
+++ b/chrome/browser/renderer_host/chrome_render_view_host_observer.cc
@@ -141,13 +141,6 @@ const Extension* ChromeRenderViewHostObserver::GetExtension() {
if (!service)
return NULL;
- // Reload the extension if it has crashed.
- // TODO(yoz): This reload doesn't happen synchronously for unpacked
- // extensions. It seems to be fast enough, but there is a race.
- // We should delay loading until the extension has reloaded.
- if (service->GetTerminatedExtension(site.host()))
- service->ReloadExtension(site.host());
-
// May be null if the extension doesn't exist, for example if somebody typos
// a chrome-extension:// URL.
return service->extensions()->GetByID(site.host());
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698