Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5054)

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 9370013: Simplify the handling of crashed extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_contents_service.cc
diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index b90d52cf1cf8d8150b0bbdff9bc9372e9f572bb3..5805dc80bd4edef8af8ef9bd03d4e66d748a57e7 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -79,6 +79,8 @@ class CrashNotificationDelegate : public NotificationDelegate {
if (!service->GetAppBackgroundContents(ASCIIToUTF16(extension_id_)))
service->LoadBackgroundContentsForExtension(profile_, extension_id_);
} else {
+ // TODO(aa): Could we just reload the ExtensionHost instead of the entire
+ // extension?
profile_->GetExtensionService()->ReloadExtension(extension_id_);
}
« no previous file with comments | « chrome/browser/background/background_application_list_model.cc ('k') | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698