Issue 9370013: Simplify the handling of crashed extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9370013: Simplify the handling of crashed extensions. (Closed)

Created:
8 years, 10 months ago by Aaron Boodman

Modified:
8 years, 10 months ago

Reviewers:

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, kkania, mihaip+watch_chromium.org, Aaron Boodman, robertshield, brettw-cc_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Simplify the handling of crashed extensions. There is no need to distinguish between loaded extensions that have crashed vs those that have not crashed. Crash recovery is an implementation detail of a few teeny parts of the system. The fact that crashed extensions were removed from the loaded list, and thereby exposed to all the clients of ExtensionService, was a bug/design flaw that got cemented into place instead of just being fixed.

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -184 lines)			Patch
M	chrome/browser/automation/automation_provider_observers.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/background/background_application_list_model.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/background/background_contents_service.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.h	View	5 chunks	+6 lines, -29 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	18 chunks	+10 lines, -73 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_view_host_observer.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View	3 chunks	+5 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/webui/options/extension_settings_handler.cc	View	5 chunks	+1 line, -27 lines	0 comments	Download