Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1608)

Unified Diff: chrome/browser/io_thread.cc

Issue 9369045: [net] HostResolverImpl + DnsTransaction + DnsConfigService = Asynchronous DNS ready for experiments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added missing implementation. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index 6ad01f64ac68477963aef845ca567c9f7517cc48..4575188b464e29afbb08cea1ed3f6b2d8ac58516 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -141,14 +141,19 @@ net::HostResolver* CreateGlobalHostResolver(net::NetLog* net_log) {
command_line.GetSwitchValueASCII(switches::kDnsServer);
net::IPAddressNumber dns_ip_number;
if (net::ParseIPLiteralToNumber(dns_ip_string, &dns_ip_number)) {
- global_host_resolver =
- net::CreateAsyncHostResolver(parallelism, dns_ip_number, net_log);
+ // TODO(szym): Somehow pass |dns_ip_number| to the DnsConfigService.
+ LOG(WARNING) << "Configuration currently ignored --dns-server";
} else {
LOG(ERROR) << "Invalid IP address specified for --dns-server: "
<< dns_ip_string;
}
}
+ if (command_line.HasSwitch(switches::kEnableAsyncDns)) {
+ global_host_resolver =
+ net::CreateAsyncHostResolver(parallelism, retry_attempts, net_log);
+ }
+
if (!global_host_resolver) {
global_host_resolver =
net::CreateSystemHostResolver(parallelism, retry_attempts, net_log);
« no previous file with comments | « no previous file | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698