Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: net/base/address_list_unittest.cc

Issue 9369045: [net] HostResolverImpl + DnsTransaction + DnsConfigService = Asynchronous DNS ready for experiments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ClientSocketFactory lifetime. Move ScopedAllowIO to StartWatch. Added DnsTask logging. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/address_list_unittest.cc
diff --git a/net/base/address_list_unittest.cc b/net/base/address_list_unittest.cc
index 3dda87a785af7a675be71d6a5afd1339839f2e15..4cb15e16cc286ddfeaf4809b5dce3d141bfaffbb 100644
--- a/net/base/address_list_unittest.cc
+++ b/net/base/address_list_unittest.cc
@@ -305,7 +305,7 @@ TEST(AddressListTest, CreateFromIPAddressList) {
sizeof(struct in_addr),
},
};
- const uint16 kPort = 80;
+ const std::string kCanonicalName = "canonical.example.com";
// Construct a list of ip addresses.
IPAddressList ip_list;
@@ -315,8 +315,11 @@ TEST(AddressListTest, CreateFromIPAddressList) {
ip_list.push_back(ip_number);
}
- AddressList test_list = AddressList::CreateFromIPAddressList(ip_list, kPort);
- EXPECT_EQ(kPort, test_list.GetPort());
+ AddressList test_list = AddressList::CreateFromIPAddressList(ip_list,
+ kCanonicalName);
+ std::string canonical_name;
+ EXPECT_TRUE(test_list.GetCanonicalName(&canonical_name));
+ EXPECT_EQ(kCanonicalName, canonical_name);
// Make sure that CreateFromIPAddressList has created an addrinfo
// chain of exactly the same length as the |tests| with correct content.

Powered by Google App Engine
This is Rietveld 408576698