[net] HostResolverImpl + DnsTransaction + DnsConfigService = Asynchronous DNS ready for experiments.

net/dns/async_host_resolver.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/async_host_resolver.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 329 matching lines @@
                    transaction) != dns_transactions_.end());
 
   // If by the time requests that caused |transaction| are cancelled, we do
   // not have a port number to associate with the result, therefore, we
   // assume the most common port, otherwise we use the port number of the
   // first request.
   KeyRequestListMap::iterator rit = requestlist_map_.find(
       std::make_pair(transaction->GetHostname(), transaction->GetType()));
   DCHECK(rit != requestlist_map_.end());
   RequestList& requests = rit->second;
-  int port = requests.empty() ? 80 : requests.front()->info().port();
 
   // Extract AddressList and TTL out of DnsResponse.
   AddressList addr_list;
   uint32 ttl = kuint32max;
   if (result == OK) {
     IPAddressList ip_addresses;
     DnsRecordParser parser = response->Parser();
     DnsResourceRecord record;
     // TODO(szym): Add stricter checking of names, aliases and address lengths.
     while (parser.ParseRecord(&record)) {
       if (record.type == transaction->GetType() &&
           (record.rdata.size() == kIPv4AddressSize ||
            record.rdata.size() == kIPv6AddressSize)) {
         ip_addresses.push_back(IPAddressNumber(record.rdata.begin(),
                                                record.rdata.end()));
         ttl = std::min(ttl, record.ttl);
       }
     }
     if (!ip_addresses.empty())
-      addr_list = AddressList::CreateFromIPAddressList(ip_addresses, port);
+      addr_list = AddressList::CreateFromIPAddressList(ip_addresses, "");
     else
       result = ERR_NAME_NOT_RESOLVED;
   }
 
+  // NOTE: This is here only to compile, but async_host_resolver* is going

[cbentzel, 2012/02/10 19:51:08]

Is this note still correct?

[szym, 2012/02/10 21:49:36]

I haven't removed async_host_resolver* yet, but that would be part of this CL. 

The tests that are using the data in dns_test_util.h will be moved to
dns_response_unittest.cc

+  // away in this CL.
+  int port = requests.empty() ? 80 : requests.front()->info().port();
+  addr_list.SetPort(port);
+
   // Run callback of every request that was depending on this DNS request,
   // also notify observers.
   for (RequestList::iterator it = requests.begin(); it != requests.end(); ++it)
     (*it)->OnAsyncComplete(result, addr_list);
 
   // It is possible that the requests that caused |transaction| to be
   // created are cancelled by the time |transaction| completes.  In that
   // case |requests| would be empty.  We are knowingly throwing away the
   // result of a DNS resolution in that case, because (a) if there are no
   // requests, we do not have info to obtain a key from, (b) DnsTransaction
@@ skipping 130 matching lines @@
         it = requests.erase(it);
       } else {
         ++it;
       }
     }
   }
   StartNewDnsRequestFor(request);
 }
 
 }  // namespace net