[net] HostResolverImpl + DnsTransaction + DnsConfigService = Asynchronous DNS ready for experiments.

net/base/address_list.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/address_list.h"
 
 #include <stdlib.h>
 
 #include "base/logging.h"
 #include "net/base/net_util.h"
@@ skipping 94 matching lines @@
 }
 
 AddressList& AddressList::operator=(const AddressList& addresslist) {
   data_ = addresslist.data_;
   return *this;
 }
 
 // static
 AddressList AddressList::CreateFromIPAddressList(
     const IPAddressList& addresses,
-    uint16 port) {
+    const std::string& canonical_name) {

[cbentzel, 2012/02/10 19:51:08]

Why were you able to get rid of port here? Was it only used in the unit test?

[szym, 2012/02/10 21:49:36]

It was only used in AsyncHostResolver, and the usecase was good. However, in
HostResolverImpl, there's an equally efficient MutableSetPort that was already
used for ProcTask, so I prefer that one for simplicity of code paths.

   DCHECK(!addresses.empty());
   struct addrinfo* head = NULL;
   struct addrinfo* next = NULL;
 
   for (IPAddressList::const_iterator it = addresses.begin();
        it != addresses.end(); ++it) {
     if (head == NULL) {
       head = next = CreateAddrInfo(*it, false);
+      if (!canonical_name.empty()) {
+        head->ai_canonname = do_strdup(canonical_name.c_str());
+      }
     } else {
       next->ai_next = CreateAddrInfo(*it, false);
       next = next->ai_next;
     }
   }
 
-  SetPortForAllAddrinfos(head, port);
   return AddressList(new Data(head, false));
 }
 
 // static
 AddressList AddressList::CreateFromIPAddress(
       const IPAddressNumber& address,
       uint16 port) {
   return CreateFromIPAddressWithCname(address, port, false);
 }
 
@@ skipping 141 matching lines @@
 AddressList CreateAddressListUsingPort(const AddressList& src, int port) {
   if (src.GetPort() == port)
     return src;
 
   AddressList out = src;
   out.SetPort(port);
   return out;
 }
 
 }  // namespace net