Issue 9369027: Remove `kMockStart` from `quota::MockStorageClient`

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9369027: Remove `kMockStart` from `quota::MockStorageClient` (Closed)

Created:
8 years, 10 months ago by Mike West

Modified:
8 years, 10 months ago

Reviewers:
kinuko

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove `kMockStart` from `quota::MockStorageClient` After landing a fix for crbug.com/94334, the mock client IDs are no longer necessary for tests (and, in fact, are counterproductive). BUG=113380 TEST=test_shell_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121444

Patch Set 1 #

Patch Set 2 : Rebasing to ToT. #

Patch Set 3 : . #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -83 lines)			Patch
M	chrome/browser/browsing_data_quota_helper_unittest.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/quota/mock_storage_client.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	webkit/quota/mock_storage_client.cc	View	1	1 chunk	+0 lines, -33 lines	0 comments	Download
M	webkit/quota/quota_client.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/quota/quota_manager_unittest.cc	View		32 chunks	+70 lines, -45 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mike West

Following up on http://codereview.chromium.org/7839029/, this CL drops the `kMockStart` client ID, along with anything that ...

8 years, 10 months ago (2012-02-09 15:51:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/9369027/7001

8 years, 10 months ago (2012-02-10 10:58:05 UTC) #3

Change committed as 121444

Expand Messages | Collapse Messages