Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 9369003: Pepper: Add a function to PPB_Flash to check if a rect is topmost. (Closed)

Created:
8 years, 10 months ago by viettrungluu
Modified:
8 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Pepper: Add a function to PPB_Flash to check if a rect is topmost. This is needed for "Flash dialogs". This is dependent on https://bugs.webkit.org/show_bug.cgi?id=78166 . TEST=check the example plugin (under flash_topmost) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122686

Patch Set 1 #

Patch Set 2 : whitespace fix #

Patch Set 3 : add stubs for InvokePrinting() and UpdateActivity() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -11 lines) Patch
M ppapi/api/private/ppb_flash.idl View 1 2 2 chunks +26 lines, -1 line 0 comments Download
M ppapi/c/private/ppb_flash.h View 1 2 4 chunks +43 lines, -4 lines 0 comments Download
M ppapi/cpp/private/flash.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/cpp/private/flash.cc View 1 2 11 chunks +69 lines, -1 line 0 comments Download
A ppapi/examples/flash_topmost/flash_topmost.cc View 1 chunk +135 lines, -0 lines 0 comments Download
A ppapi/examples/flash_topmost/flash_topmost.html View 1 chunk +74 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +10 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.cc View 1 2 6 chunks +55 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.cc View 1 2 5 chunks +46 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
8 years, 10 months ago (2012-02-09 00:02:31 UTC) #1
brettw
lgtm
8 years, 10 months ago (2012-02-09 19:26:12 UTC) #2
viettrungluu
On 2012/02/09 19:26:12, brettw wrote: > lgtm I added stubs for InvokePrinting() and UpdateActivity() -- ...
8 years, 10 months ago (2012-02-18 00:26:06 UTC) #3
brettw
lgtm
8 years, 10 months ago (2012-02-18 00:31:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/9369003/5001
8 years, 10 months ago (2012-02-18 00:33:31 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-18 08:16:23 UTC) #6
Change committed as 122686

Powered by Google App Engine
This is Rietveld 408576698