Move indexed db files from content/renderer to content/common.

Move indexed db files from content/renderer to content/common.

http://codereview.chromium.org/9375024/ enables indexed db in shared workers.

BUG=112855
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121669

[dgrogan, 2012-02-10 02:22:30]

I'll rename the classes (Renderer -> Proxy) in a later patch.

For some bikeshedding, I picked "proxy" because these can be read as "proxy to
the WebIDB[ObjectStore]Impl".  I also considered
"ipc_proxy_to_web_idb_objectstore_impl", "client_web_idb_objectstore_impl" and
"child_web_idb_objectstore_impl".

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/indexed_db_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/indexed_db_dispatcher.cc:16: #include
"content/renderer/render_view_impl.h"
This is the only layer violation that I know of.

[dgrogan, 2012-02-10 02:23:05]

Now, actually +jsbell.

[jsbell, 2012-02-10 18:57:27]

lgtm with nits/questions/TODO suggestion

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/indexed_db_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/indexed_db_dispatcher.cc:15: #include
"content/common/child_thread.h"
Nit: include ordering

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/indexed_db_dispatcher.cc:16: #include
"content/renderer/render_view_impl.h"
On 2012/02/10 02:22:30, dgrogan wrote:
> This is the only layer violation that I know of.

And only used for the RenderViewImpl::FromWebView(web_frame->view()) ... if
(!render_view) ... "must be shutting down" check, right? If so, add a TODO/crbug
to add a more appropriate method to check for "is this web view any good?"

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/indexed_db_dispatcher.h (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/indexed_db_dispatcher.h:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
The pre-commit license checks are going to updating the year to 2012 in every
file. Might as well do that now.

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/proxy_webidbcursor_impl.cc (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/proxy_webidbcursor_impl.cc:9: #include
"content/common/child_thread.h"
Nit: Include ordering

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/proxy_webidbcursor_impl.h (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/proxy_webidbcursor_impl.h:18: class
RendererWebIDBCursorImpl : public WebKit::WebIDBCursor {
Is the plan to rename these from RendererWebIDB* to (e.g.) ProxyWebIDB* in a
follow-up CL?

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/proxy_webidbdatabase_impl.cc (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/proxy_webidbdatabase_impl.cc:11: #include
"content/common/child_thread.h"
Nit: Include ordering

https://chromiumcodereview.appspot.com/9368053/diff/1/content/worker/worker_w...
File content/worker/worker_webkitplatformsupport_impl.cc (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/worker/worker_w...
content/worker/worker_webkitplatformsupport_impl.cc:12: #include
"content/common/indexed_db/proxy_webidbfactory_impl.h"
Not used yet, right?

[dgrogan, 2012-02-10 19:57:20]

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/indexed_db_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/indexed_db_dispatcher.cc:15: #include
"content/common/child_thread.h"
On 2012/02/10 18:57:29, jsbell wrote:
> Nit: include ordering

Done.  (I thought we had a presubmit check for that.)

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/indexed_db_dispatcher.cc:16: #include
"content/renderer/render_view_impl.h"
On 2012/02/10 18:57:29, jsbell wrote:
> On 2012/02/10 02:22:30, dgrogan wrote:
> > This is the only layer violation that I know of.
> 
> And only used for the RenderViewImpl::FromWebView(web_frame->view()) ... if
> (!render_view) ... "must be shutting down" check, right?

That's right.

> If so, add a TODO/crbug
> to add a more appropriate method to check for "is this web view any good?"

Done.

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/indexed_db_dispatcher.h (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/indexed_db_dispatcher.h:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
On 2012/02/10 18:57:29, jsbell wrote:
> The pre-commit license checks are going to updating the year to 2012 in every
> file. Might as well do that now.

Done.

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/proxy_webidbcursor_impl.cc (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/proxy_webidbcursor_impl.cc:9: #include
"content/common/child_thread.h"
On 2012/02/10 18:57:29, jsbell wrote:
> Nit: Include ordering

Done.

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/proxy_webidbcursor_impl.h (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/proxy_webidbcursor_impl.h:18: class
RendererWebIDBCursorImpl : public WebKit::WebIDBCursor {
On 2012/02/10 18:57:29, jsbell wrote:
> Is the plan to rename these from RendererWebIDB* to (e.g.) ProxyWebIDB* in a
> follow-up CL?

Yes.

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
File content/common/indexed_db/proxy_webidbdatabase_impl.cc (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/common/indexed_...
content/common/indexed_db/proxy_webidbdatabase_impl.cc:11: #include
"content/common/child_thread.h"
On 2012/02/10 18:57:29, jsbell wrote:
> Nit: Include ordering

Done.

https://chromiumcodereview.appspot.com/9368053/diff/1/content/worker/worker_w...
File content/worker/worker_webkitplatformsupport_impl.cc (right):

https://chromiumcodereview.appspot.com/9368053/diff/1/content/worker/worker_w...
content/worker/worker_webkitplatformsupport_impl.cc:12: #include
"content/common/indexed_db/proxy_webidbfactory_impl.h"
On 2012/02/10 18:57:29, jsbell wrote:
> Not used yet, right?

Ah right, removed.

[jsbell, 2012-02-10 20:03:00]

lgtm

[dgrogan, 2012-02-10 20:14:27]

jam, could you review as OWNER of content/renderer?

[dgrogan, 2012-02-10 23:38:16]

Josh, could you look at the checkdeps fix?

[jsbell, 2012-02-10 23:57:37]

lgtm with nit

http://codereview.chromium.org/9368053/diff/9050/content/common/child_thread.h
File content/common/child_thread.h (right):

http://codereview.chromium.org/9368053/diff/9050/content/common/child_thread....
content/common/child_thread.h:15: #include
"third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
Nit: include ordering

http://codereview.chromium.org/9368053/diff/9050/content/renderer/renderer_we...
File content/renderer/renderer_webkitplatformsupport_impl.cc (right):

http://codereview.chromium.org/9368053/diff/9050/content/renderer/renderer_we...
content/renderer/renderer_webkitplatformsupport_impl.cc:676: if (!web_frame)
This should eventually change to use the new IsWebFrameValid method, but not
now. :)

[dgrogan, 2012-02-11 00:05:24]

John, I think this is now _actually_ ready for you to look at.

http://codereview.chromium.org/9368053/diff/9050/content/common/child_thread.h
File content/common/child_thread.h (right):

http://codereview.chromium.org/9368053/diff/9050/content/common/child_thread....
content/common/child_thread.h:15: #include
"third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
On 2012/02/10 23:57:38, jsbell wrote:
> Nit: include ordering

Moved to the .cc file, and in the proper order.

[jam, 2012-02-11 02:32:07]

http://codereview.chromium.org/9368053/diff/10013/content/common/child_thread.cc
File content/common/child_thread.cc (right):

http://codereview.chromium.org/9368053/diff/10013/content/common/child_thread...
content/common/child_thread.cc:25: #include
"third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
nit: not needed

http://codereview.chromium.org/9368053/diff/10013/content/common/indexed_db/p...
File content/common/indexed_db/proxy_webidbcursor_impl.h (right):

http://codereview.chromium.org/9368053/diff/10013/content/common/indexed_db/p...
content/common/indexed_db/proxy_webidbcursor_impl.h:18: class
RendererWebIDBCursorImpl : public WebKit::WebIDBCursor {
"Proxy" seem redundant. why not just WebIDBCursorImpl? That's what we do with
other WebKit interfaces (i.e. WebPlugin, WebSharedWorkerRepositoryImpl off the
top of my head).

[dgrogan, 2012-02-11 03:03:25]

http://codereview.chromium.org/9368053/diff/10013/content/common/child_thread.cc
File content/common/child_thread.cc (right):

http://codereview.chromium.org/9368053/diff/10013/content/common/child_thread...
content/common/child_thread.cc:25: #include
"third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
On 2012/02/11 02:32:07, John Abd-El-Malek wrote:
> nit: not needed

Done.

http://codereview.chromium.org/9368053/diff/10013/content/common/indexed_db/p...
File content/common/indexed_db/proxy_webidbcursor_impl.h (right):

http://codereview.chromium.org/9368053/diff/10013/content/common/indexed_db/p...
content/common/indexed_db/proxy_webidbcursor_impl.h:18: class
RendererWebIDBCursorImpl : public WebKit::WebIDBCursor {
On 2012/02/11 02:32:07, John Abd-El-Malek wrote:
> "Proxy" seem redundant. why not just WebIDBCursorImpl? That's what we do with
> other WebKit interfaces (i.e. WebPlugin, WebSharedWorkerRepositoryImpl off the
> top of my head).

We already have a WebIDBCursorImpl in
third_party/WebKit/Source/WebKit/chromium/src that's used in the browser
process.  We have two implementations of all the IDB WebKit API classes, one for
each of the renderer and browser.  So I'd prefer to leave some prefix on there
to take the place of "renderer", even if it's not "proxy".

[jam, 2012-02-12 01:09:46]

lgtm

http://codereview.chromium.org/9368053/diff/10013/content/common/indexed_db/p...
File content/common/indexed_db/proxy_webidbcursor_impl.h (right):

http://codereview.chromium.org/9368053/diff/10013/content/common/indexed_db/p...
content/common/indexed_db/proxy_webidbcursor_impl.h:18: class
RendererWebIDBCursorImpl : public WebKit::WebIDBCursor {
On 2012/02/11 03:03:26, dgrogan wrote:
> On 2012/02/11 02:32:07, John Abd-El-Malek wrote:
> > "Proxy" seem redundant. why not just WebIDBCursorImpl? That's what we do
with
> > other WebKit interfaces (i.e. WebPlugin, WebSharedWorkerRepositoryImpl off
the
> > top of my head).
> 
> We already have a WebIDBCursorImpl in
> third_party/WebKit/Source/WebKit/chromium/src that's used in the browser
> process.  We have two implementations of all the IDB WebKit API classes, one
for
> each of the renderer and browser.  So I'd prefer to leave some prefix on there
> to take the place of "renderer", even if it's not "proxy".

ah, I wasn't aware of that, sorry.

[commit-bot: I haz the power, 2012-02-12 09:56:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9368053/10015

[commit-bot: I haz the power, 2012-02-12 18:10:05]

Change committed as 121669