Removed WebTextCheckingResult legacy API use.

content/public/common/webkit_param_traits.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // NOTE: New trait definitions that will be used by Chrome Frame must be placed
 // in common_param_traits2.cc.
 
 #include "content/public/common/webkit_param_traits.h"
 
 #include "base/string_number_conversions.h"
@@ skipping 292 matching lines @@
   l->append("(");
   LogParam(p.name, l);       l->append(", ");
   LogParam(p.path, l);       l->append(", ");
   LogParam(p.version, l);    l->append(", ");
   LogParam(p.desc, l);       l->append(", ");
   LogParam(p.mime_types, l); l->append(", ");
   LogParam(p.type, l);
   l->append(")");
 }
 
+void ParamTraits<WebKit::WebTextCheckingResult>::Write(Message* m,
+                                                       const param_type& p) {
+  WriteParam(m, p.type);
+  WriteParam(m, p.location);
+  WriteParam(m, p.length);
+  WriteParam(m, static_cast<string16>(p.replacement));
+}
+
+bool ParamTraits<WebKit::WebTextCheckingResult>::Read(const Message* m,
+                                                      void** iter,
+                                                      param_type* p) {
+    bool ok =
+        ReadParam(m, iter, &p->type) &&
+        ReadParam(m, iter, &p->location) &&
+        ReadParam(m, iter, &p->length);
+    if (!ok)
+      return false;
+    string16 replacement;
+    if (!ReadParam(m, iter, &replacement))
+      return false;
+    p->replacement.assign(replacement);

[darin (slow to review), 2012/02/15 05:54:26]

I don't think we want this.  It means creating a WebString in the browser
process.

Some suggestions:
1- Break replacement out of WebTextCheckingResult.  (This sounds bad since you
want arrays of WebTextCheckingResult objects.)
2- Define a similar struct for use in Chromium.  Copy WebTextCheckingResult to
that struct.

I'd probably go with #2.

+    return true;
+}
+
+void ParamTraits<WebKit::WebTextCheckingResult>::Log(const param_type& p,
+                                                     std::string* l) {
+  l->append("(");
+  LogParam(p.type, l);         l->append(", ");
+  LogParam(p.location, l);     l->append(", ");
+  LogParam(p.length, l);       l->append(", ");
+  LogParam(static_cast<string16>(p.replacement), l);  l->append(", ");
+  l->append(")");
+}
+
 void ParamTraits<webkit::forms::PasswordForm>::Write(Message* m,
                                                      const param_type& p) {
   WriteParam(m, p.signon_realm);
   WriteParam(m, p.origin);
   WriteParam(m, p.action);
   WriteParam(m, p.submit_element);
   WriteParam(m, p.username_element);
   WriteParam(m, p.username_value);
   WriteParam(m, p.password_element);
   WriteParam(m, p.password_value);
@@ skipping 21 matching lines @@
       ReadParam(m, iter, &p->ssl_valid) &&
       ReadParam(m, iter, &p->preferred) &&
       ReadParam(m, iter, &p->blacklisted_by_user);
 }
 void ParamTraits<webkit::forms::PasswordForm>::Log(const param_type& p,
                                                    std::string* l) {
   l->append("<PasswordForm>");
 }
 
 }  // namespace IPC