Expose a static configuration value for the host to use for URLRequestTestHTTP tests.

net/url_request/url_request_test_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_test_util.h"
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/threading/thread.h"
@@ skipping 486 matching lines @@
   event_order_[req_id] += "OnAuthRequired\n";
   EXPECT_TRUE(next_states_[req_id] & kStageAuthRequired) <<
       event_order_[req_id];
   next_states_[req_id] = kStageBeforeSendHeaders |
       kStageHeadersReceived |  // Request canceled by delegate simulates empty
                                // response.
       kStageResponseStarted |  // data: URLs do not trigger sending headers
       kStageBeforeRedirect;  // a delegate can trigger a redirection
   return net::NetworkDelegate::AUTH_REQUIRED_RESPONSE_NO_ACTION;
 }
+
+namespace {
+char url_request_test_http_host_[256] = "127.0.0.1";

[eroman, 2012/02/16 02:41:00]

First off, please prefix globals with "g_".

Secondly, since this is test code, I think it is fine to have static
initializers. So in other words, you can get away with defining this global as a
std::string and not needing to do the fancy copying of C strings.

[erikwright (departed), 2012/02/16 16:04:13]

Done.

+}  // namespace
+
+void set_url_request_test_http_host(const std::string& host) {
+  strncpy(url_request_test_http_host_,
+         host.c_str(),
+         arraysize(url_request_test_http_host_) - 1);
+  url_request_test_http_host_[arraysize(url_request_test_http_host_) - 1] = 0;

[eroman, 2012/02/16 02:41:00]

nit: If we have a host literal string longer than 255 something is not right :-)
This is fine as-is, but you might alternately consider asserting the length is
smaller at the start.

[erikwright (departed), 2012/02/16 16:04:13]

N/A.

+}
+
+char* url_request_test_http_host() {

[eroman, 2012/02/16 02:41:00]

can you return a const char* so caller can't mutate the array?

[erikwright (departed), 2012/02/16 16:04:13]

Done.

+  return url_request_test_http_host_;
+}