Add a '--host' option to testserver.py .

Add a '--host' option to testserver.py .

This option selects the address upon which the server listens. Clients connections are only accepted from this address. The default is 127.0.0.1 (the previously used value). The restriction on clients is applied even in the absence of a host argument. In other words, without using the new argument, this CL will add a restriction on clients.

BUG=114369
TEST=net_unittests still pass

[erikwright (departed), 2012-02-15 15:47:25]

See also this change to test_server.cc: http://codereview.chromium.org/9369029/

and this change to expose a static host parameter for the tests in question:
http://codereview.chromium.org/9368031/

Two more changes just need some tidying up (to consult that parameter in
url_request_unittest.cc and to set the parameter during chrome_frame_net_tests
initialization).

Another change to actually set that parameter during chrome_frame_net_tests
runs, 

Motivation is mysterious failures in chrome_frame_net_tests when they are run
over loopback adapter. These failures go away when another adapter is used.

The failure has been localized to somewhere between socket.read() in python and
ws2_32!send in urlmon (via Internet Explorer). Further diagnosis will probably
require kernel debugging.

This workaround fixes the issue (dozens of try jobs without encountering the
failure, which otherwise occurred nearly every run) and will bring us closer to
getting the chrome_frame_net_tests back on the waterfall.

[Paweł Hajdan Jr., 2012-02-15 17:11:01]

Please post more details why this is needed. Main reason is that I'd like to
understand the problem as much as possible (I'm aware we probably don't
understand it fully and this patch is only a workaround).

http://codereview.chromium.org/9368030/diff/1/net/tools/testserver/testserver.py
File net/tools/testserver/testserver.py (right):

http://codereview.chromium.org/9368030/diff/1/net/tools/testserver/testserver...
net/tools/testserver/testserver.py:107: """This is a specialization of
StoppableHTTPerver that add client
nit: "that adds", note the "s".

http://codereview.chromium.org/9368030/diff/1/net/tools/testserver/testserver...
net/tools/testserver/testserver.py:272: """This is a specialization of FTPServer
that add client
nit: "that adds"

[erikwright (departed), 2012-02-15 17:55:31]

On 2012/02/15 17:11:01, Paweł Hajdan Jr. wrote:
> Please post more details why this is needed. Main reason is that I'd like to
> understand the problem as much as possible (I'm aware we probably don't
> understand it fully and this patch is only a workaround).

Please see the linked bug (http://crbug.com/114369).

> 
>
http://codereview.chromium.org/9368030/diff/1/net/tools/testserver/testserver.py
> File net/tools/testserver/testserver.py (right):
> 
>
http://codereview.chromium.org/9368030/diff/1/net/tools/testserver/testserver...
> net/tools/testserver/testserver.py:107: """This is a specialization of
> StoppableHTTPerver that add client
> nit: "that adds", note the "s".
> 
>
http://codereview.chromium.org/9368030/diff/1/net/tools/testserver/testserver...
> net/tools/testserver/testserver.py:272: """This is a specialization of
FTPServer
> that add client
> nit: "that adds"

[akalin, 2012-02-15 23:19:44]

I'll leave this review to Pawel (note that the OWNERS file for tools/testserver
isn't 'set noparent'; I'm only in there really for sync-related changes.)

[erikwright (departed), 2012-02-16 15:01:49]

On 2012/02/15 23:19:44, akalin wrote:
> I'll leave this review to Pawel (note that the OWNERS file for
tools/testserver
> isn't 'set noparent'; I'm only in there really for sync-related changes.)

This CL has been integrated into http://codereview.chromium.org/9369029/ per
your request.