Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 9365078: Rename the ephemeral_users field in the device policy protobuf (Closed)

Created:
8 years, 10 months ago by use bartfab instead
Modified:
8 years, 10 months ago
Reviewers:
xiyuan, pastarmovj
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Rename the ephemeral_users field in the device policy protobuf This CL renames the "ephemeral_users" in the device policy protobuf to "ephemeral_users_enabled", making it clear that this is a Boolean setting. BUG=chromium-os:26406 TEST=unit_test *Policy* and CrosSettingsTest.SetEphemeralUsersEnabled TEST=chrome builds and runs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122145

Patch Set 1 #

Patch Set 2 : Fixed reference to Chrome OS bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M chrome/browser/chromeos/cros_settings_names.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros_settings_names.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros_settings_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/device_settings_provider.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/stub_cros_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/proto/chrome_device_policy.proto View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
use bartfab instead
Hi Julian, can you please review?
8 years, 10 months ago (2012-02-15 02:35:25 UTC) #1
use bartfab instead
Hi Xiyuan, I see you worked on the files that this CL touches in the ...
8 years, 10 months ago (2012-02-15 17:37:26 UTC) #2
xiyuan
On 2012/02/15 17:37:26, bartfab wrote: > Hi Xiyuan, I see you worked on the files ...
8 years, 10 months ago (2012-02-15 17:54:20 UTC) #3
pastarmovj
LGTM sorry for the delay on that one. It sort of slipped through the cracks ...
8 years, 10 months ago (2012-02-15 17:54:59 UTC) #4
use bartfab instead
> BTW, you probabaly meant: BUG=chromium-os:26406. Right now, it points to a > chromium bug. ...
8 years, 10 months ago (2012-02-15 18:08:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@google.com/9365078/5001
8 years, 10 months ago (2012-02-15 18:13:03 UTC) #6
commit-bot: I haz the power
8 years, 10 months ago (2012-02-15 21:05:24 UTC) #7
Change committed as 122145

Powered by Google App Engine
This is Rietveld 408576698