src/hydrogen.cc - Issue 9365057: Relax TransitionElementsKind DependsOn/Changes dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 9365057: Relax TransitionElementsKind DependsOn/Changes dependencies. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Ensure that MapChecks before and after transitions are recognized as dupes Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index a6b60b1f77a8fc439409096fbd88cd6c7b79006c..34504140113e7e9e07292644bfc5fea430836aaf 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -1192,7 +1192,8 @@ void HValueMap::Kill(GVNFlagSet flags) {

// Now possibly drop directly indexed element.

value = array_[i].value;

- if (value->gvn_flags().ContainsAnyOf(depends_flags)) { // Drop it.

+ if (value->gvn_flags().ContainsAnyOf(depends_flags) &&

+ !value->IsTransitionElementsKind()) { // Drop it.

fschneider 2012/02/15 15:36:48 I don't understand why skipping transition instruc

danno 2012/02/16 13:08:52 Done.

count_--;

int head = array_[i].next;

if (head == kNil) {

@@ -4454,7 +4455,7 @@ HValue* HGraphBuilder::HandlePolymorphicElementAccess(HValue* object,

Handle<Map> map = maps->at(i);

ASSERT(map->IsMap());

if (!transition_target.at(i).is_null()) {

- object = AddInstruction(new(zone()) HTransitionElementsKind(

+ AddInstruction(new(zone()) HTransitionElementsKind(

object, map, transition_target.at(i)));

} else {

type_todo[map->elements_kind()] = true;

« no previous file with comments | « src/flag-definitions.h ('k') | src/hydrogen-instructions.h » ('j') | test/mjsunit/elements-transition-hoisting.js » ('J')