Issue 9363058: Implement minimal IconManager and IconLoader for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9363058: Implement minimal IconManager and IconLoader for Android. (Closed)

Created:
8 years, 10 months ago by Yaron

Modified:
8 years, 10 months ago

Reviewers:
jam

CC:
chromium-reviews, tonyg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement minimal IconManager and IconLoader for Android. Another step towards linking sync_unit_tests BUG=113487 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122040

Patch Set 2 : nit #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
A	chrome/browser/icon_loader_android.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A	chrome/browser/icon_manager_android.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm http://codereview.chromium.org/9363058/diff/1/chrome/browser/icon_loader_android.cc File chrome/browser/icon_loader_android.cc (right): http://codereview.chromium.org/9363058/diff/1/chrome/browser/icon_loader_android.cc#newcode7 chrome/browser/icon_loader_android.cc:7: nit: extra blank line

8 years, 10 months ago (2012-02-15 01:31:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9363058/2002

8 years, 10 months ago (2012-02-15 02:36:16 UTC) #3

Change committed as 122040

Expand Messages | Collapse Messages

Issue 9363058: Implement minimal IconManager and IconLoader for Android. (Closed)

Description

Patch Set 1 #

Patch Set 2 : nit #

Messages