Issue 9363013: Fix integer issues in a way that caters for both 32-bit and 64-bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9363013: Fix integer issues in a way that caters for both 32-bit and 64-bit. (Closed)

Created:
8 years, 10 months ago by Chris Evans

Modified:
8 years, 9 months ago

Reviewers:
Will Drewry

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Pull in tweak from upstream. Hits sign extension in 64-bit. BUG=116162

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	third_party/libpng/README.chromium	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	third_party/libpng/pngrutil.c	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 8 (0 generated)

Will Drewry

LGTM The checking looks correct even though I hate relying on uint wrap (even if ...

8 years, 10 months ago (2012-02-08 03:54:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/9363013/2002

8 years, 10 months ago (2012-02-08 05:50:21 UTC) #5

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

8 years, 10 months ago (2012-02-08 06:55:50 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/9363013/2002

8 years, 10 months ago (2012-02-08 17:35:39 UTC) #7

Change committed as 121019