Add Media device notification to SystemMonitor and Mac impl

base/system_monitor/system_monitor_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/system_monitor/system_monitor.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 
 class PowerTest : public SystemMonitor::PowerObserver {
@@ skipping 72 matching lines @@
   system_monitor.ProcessPowerMessage(SystemMonitor::RESUME_EVENT);
   loop.RunAllPending();
   EXPECT_EQ(test[0].resumes(), 1);
 
   // Send a duplicate resume notification.  This should be suppressed.
   system_monitor.ProcessPowerMessage(SystemMonitor::RESUME_EVENT);
   loop.RunAllPending();
   EXPECT_EQ(test[0].resumes(), 1);
 }
 
 class DevicesChangedTest : public SystemMonitor::DevicesChangedObserver {

[tpayne, 2012/02/15 00:56:30]

As mentioned on chat, this would be better using gmock. I'd prefer to see it in
someplace like base/testing so it could be reused in other tests.

[vandebo (ex-Chrome), 2012/02/15 22:28:25]

Done.

  public:
-  DevicesChangedTest()
-      : changes_(0) {
+  DevicesChangedTest() : changes_(0), media_attaches_(0), media_detaches_(0) {
   }
 
   // DevicesChangedObserver callbacks.
   virtual void OnDevicesChanged() OVERRIDE {
     changes_++;
   }
 
+  virtual void OnMediaDeviceAttached(const SystemMonitor::DeviceIdType& id,
+                                     const std::string& name,
+                                     const FilePath& path) OVERRIDE {
+    media_attaches_++;
+  }
+  virtual void OnMediaDeviceDetached(
+      const SystemMonitor::DeviceIdType& name) OVERRIDE {
+    media_detaches_++;
+  }
+
   // Test status counts.
   int changes() const { return changes_; }
+  int media_attaches() const { return media_attaches_; }
+  int media_detaches() const { return media_detaches_; }
 
  private:
   int changes_;  // Count of OnDevicesChanged notifications.
+  int media_attaches_;  // Count of OnMediaDeviceAttached notifications.
+  int media_detaches_;  // Count of OnMediaDeviceDetached notifications.
 
   DISALLOW_COPY_AND_ASSIGN(DevicesChangedTest);
 };
 
 TEST(SystemMonitor, DeviceChangeNotifications) {
   const int kObservers = 5;
 
   // Initialize a message loop for this to run on.
   MessageLoop loop;
 
 #if defined(OS_MACOSX)
   SystemMonitor::AllocateSystemIOPorts();
 #endif
 
   SystemMonitor system_monitor;
   DevicesChangedTest test[kObservers];
   for (int index = 0; index < kObservers; ++index)
     system_monitor.AddDevicesChangedObserver(&test[index]);
 
   system_monitor.ProcessDevicesChanged();
   loop.RunAllPending();
   EXPECT_EQ(1, test[0].changes());
+  EXPECT_EQ(0, test[0].media_attaches());
+  EXPECT_EQ(0, test[0].media_detaches());
 
   system_monitor.ProcessDevicesChanged();
   system_monitor.ProcessDevicesChanged();
   loop.RunAllPending();
   EXPECT_EQ(3, test[0].changes());
+  EXPECT_EQ(0, test[0].media_attaches());
+  EXPECT_EQ(0, test[0].media_detaches());
+
+  system_monitor.ProcessMediaDeviceAttached(
+      1, "media device", FilePath(FILE_PATH_LITERAL("path")));
+  loop.RunAllPending();
+  EXPECT_EQ(3, test[0].changes());
+  EXPECT_EQ(1, test[0].media_attaches());
+  EXPECT_EQ(0, test[0].media_detaches());
+
+  system_monitor.ProcessMediaDeviceDetached(1);
+  system_monitor.ProcessMediaDeviceDetached(2);
+  loop.RunAllPending();
+  EXPECT_EQ(3, test[0].changes());
+  EXPECT_EQ(1, test[0].media_attaches());
+  EXPECT_EQ(2, test[0].media_detaches());
 }
 
 }  // namespace base