Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9361065: reland 121901, PPAPI: Add unlocking for PPP calls and callbacks... (Closed)

Created:
8 years, 10 months ago by dmichael (off chromium)
Modified:
8 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Visibility:
Public.

Description

reland 121901, PPAPI: Add unlocking for PPP calls and callbacks... """ With this patch, ppapi_tests pass locally when building with enable_pepper_threading=1. (They didn't before). TODO: Test more calls off the main thread, make sync completion callbacks work. BUG=92909 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121901 """ TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122001

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -61 lines) Patch
M ppapi/proxy/plugin_dispatcher.cc View 3 chunks +15 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_core_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.cc View 8 chunks +11 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_message_loop_proxy.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_testing_proxy.cc View 1 5 chunks +9 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_var_deprecated_proxy.cc View 12 chunks +14 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_class_proxy.cc View 6 chunks +17 lines, -10 lines 0 comments Download
M ppapi/proxy/ppp_graphics_3d_proxy.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/proxy/ppp_input_event_proxy.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/proxy/ppp_instance_private_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppp_messaging_proxy.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ppapi/proxy/ppp_mouse_lock_proxy.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/proxy/ppp_video_decoder_proxy.cc View 1 chunk +17 lines, -8 lines 0 comments Download
M ppapi/proxy/serialized_var_unittest.cc View 8 chunks +8 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppp_instance_combined.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M ppapi/shared_impl/proxy_lock.h View 3 chunks +75 lines, -0 lines 0 comments Download
M ppapi/shared_impl/proxy_lock.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/shared_impl/tracked_callback.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ppapi/thunk/enter.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/enter.cc View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
No reviewers yet.
8 years, 10 months ago (2012-02-14 22:09:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9361065/1
8 years, 10 months ago (2012-02-14 22:12:51 UTC) #2
commit-bot: I haz the power
Can't apply patch for file ppapi/proxy/ppb_testing_proxy.cc. While running patch -p1 --forward --force; patching file ppapi/proxy/ppb_testing_proxy.cc ...
8 years, 10 months ago (2012-02-14 22:12:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9361065/4025
8 years, 10 months ago (2012-02-14 23:15:31 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-15 01:44:48 UTC) #5 
Change committed as 122001

Powered by Google App Engine
This is Rietveld 408576698