Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: chrome/browser/chromeos/offline/offline_load_page_unittest.cc

Issue 9361047: Fix OfflineLoadPageTest (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/offline/offline_load_page_unittest.cc
===================================================================
--- chrome/browser/chromeos/offline/offline_load_page_unittest.cc (revision 121009)
+++ chrome/browser/chromeos/offline/offline_load_page_unittest.cc (working copy)
@@ -71,7 +71,7 @@
}
void ShowInterstitial(const char* url) {
- new TestOfflineLoadPage(contents(), GURL(url), this);
+ (new TestOfflineLoadPage(contents(), GURL(url), this))->Show();
}
// Returns the OfflineLoadPage currently showing or NULL if none is
@@ -97,8 +97,7 @@
test_page_->OnBlockingPageComplete(proceed);
}
-// Tests are disabled due to crash. see crbug.com/113219.
-TEST_F(OfflineLoadPageTest, DISABLED_OfflinePageProceed) {
+TEST_F(OfflineLoadPageTest, OfflinePageProceed) {
// Start a load.
Navigate(kURL1, 1);
// Load next page.
@@ -127,7 +126,7 @@
}
// Tests showing an offline page and not proceeding.
-TEST_F(OfflineLoadPageTest, DISABLED_OfflinePageDontProceed) {
+TEST_F(OfflineLoadPageTest, OfflinePageDontProceed) {
// Start a load.
Navigate(kURL1, 1);
controller().LoadURL(GURL(kURL2), content::Referrer(),
« no previous file with comments | « chrome/browser/chromeos/offline/offline_load_page.cc ('k') | chrome/browser/renderer_host/offline_resource_throttle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698