Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 9361039: Adds a stub method & classes for those which aren't used in android. (Closed)

Created:
8 years, 10 months ago by Satish
Modified:
8 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, John Grabowski, Yaron, Min Qin
Visibility:
Public.

Description

Adds a stub method & classes for those which aren't used in android. Also excludes usage of WebMediaPlayerImpl from render_view_impl.cc as it will be implemented differently for android in a future CL. These changes are required to make progress in getting content_unittests link for android. BUG=113218 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
A content/common/font_list_android.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 5 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Satish
8 years, 10 months ago (2012-02-08 16:44:26 UTC) #1
jam
lgtm
8 years, 10 months ago (2012-02-08 17:05:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/9361039/1
8 years, 10 months ago (2012-02-08 17:14:17 UTC) #3
commit-bot: I haz the power
Try job failure for 9361039-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 10 months ago (2012-02-08 17:43:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/9361039/1
8 years, 10 months ago (2012-02-08 20:06:41 UTC) #5
commit-bot: I haz the power
Try job failure for 9361039-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 10 months ago (2012-02-08 20:43:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/9361039/1
8 years, 10 months ago (2012-02-08 21:05:33 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-02-08 23:58:16 UTC) #8
Change committed as 121095

Powered by Google App Engine
This is Rietveld 408576698