Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 9360032: linux: migrate linker --threads flag out of gyp (Closed)

Created:
8 years, 10 months ago by Evan Martin
Modified:
8 years, 10 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

linux: migrate linker --threads flag out of gyp This just copies the flags used within gyp. BUG=gyp:250 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Martin
I'm not too happy about this code: it seems 5 threads might make more sense ...
8 years, 10 months ago (2012-02-08 22:17:46 UTC) #1
Evan Martin
reference: http://code.google.com/p/gyp/source/browse/trunk/pylib/gyp/generator/make.py#1914
8 years, 10 months ago (2012-02-08 22:18:15 UTC) #2
Lei Zhang
lgtm
8 years, 10 months ago (2012-02-08 22:20:25 UTC) #3
Nico
lgtm
8 years, 10 months ago (2012-02-08 22:22:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan@chromium.org/9360032/1
8 years, 10 months ago (2012-02-08 22:22:53 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-09 01:59:42 UTC) #6
Change committed as 121148

Powered by Google App Engine
This is Rietveld 408576698