Issue 9360028: Presubmit change to add android trybots when needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9360028: Presubmit change to add android trybots when needed. (Closed)

Created:
8 years, 10 months ago by John Grabowski

Modified:
8 years, 10 months ago

Reviewers:
cmp, Nicolas Sylvain, Jeff Bailey (chromium), M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Presubmit change to add android trybots when needed. Also add warning in android_all.gyp that extra targets in 'all' can have a significant impact on the try load so coordinate appropriately. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121560

Patch Set 1 #

Total comments: 1

Patch Set 2 : MA feedback #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
	M	build/all_android.gyp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://chromiumcodereview.appspot.com/9360028/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): http://chromiumcodereview.appspot.com/9360028/diff/1/PRESUBMIT.py#newcode347 PRESUBMIT.py:347: def GetAndroidTrySlaves(project, change): Don't make it a separate function ...

8 years, 10 months ago (2012-02-09 00:36:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrg@chromium.org/9360028/2002

8 years, 10 months ago (2012-02-10 21:32:14 UTC) #5

Change committed as 121560

Expand Messages | Collapse Messages