Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 9359002: [ntp] fix font measuring hack (Closed)

Created:
8 years, 10 months ago by Evan Stade
Modified:
8 years, 10 months ago
Reviewers:
csilv
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

[ntp] fix font measuring hack one more style (font: -webkit-small-control) was needed to make the \#fontMeasuringDiv exactly match the input divs' appearance. BUG=96889 TEST=in mac, all languages look good: fr, ko, ja, de, en, ml Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/ntp4/new_tab.css View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Evan Stade
if you could check this on Mac (just German is fine) I'd be much obliged
8 years, 10 months ago (2012-02-08 00:57:17 UTC) #1
Evan Stade
ping
8 years, 10 months ago (2012-02-09 23:14:17 UTC) #2
csilv
LGTM tested it on all the languagues requested. Note some elements, such as the tile ...
8 years, 10 months ago (2012-02-09 23:31:14 UTC) #3
Evan Stade
On 2012/02/09 23:31:14, csilv wrote: > LGTM > > tested it on all the languagues ...
8 years, 10 months ago (2012-02-10 02:34:02 UTC) #4
Evan Stade
thanks for testing!
8 years, 10 months ago (2012-02-10 02:46:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/9359002/1
8 years, 10 months ago (2012-02-10 02:46:41 UTC) #6
commit-bot: I haz the power
8 years, 10 months ago (2012-02-10 04:11:56 UTC) #7
Change committed as 121402

Powered by Google App Engine
This is Rietveld 408576698