chrome/test/data/extensions/api_test/media_gallery/manifest.json - Issue 9358076: Initial extension bindings for Media Gallery API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/media_gallery/manifest.json

Issue 9358076: Initial extension bindings for Media Gallery API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/renderer/extensions/extension_dispatcher.cc ('K') | « chrome/test/data/extensions/api_test/README.txt ('k') | chrome/test/data/extensions/api_test/media_gallery/test.html » ('j') | chrome/test/data/extensions/api_test/media_gallery/test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "chrome.experimental.mediaGalleries",

	3 "version": "0.1",

	4 "manifest_version": 2,

	5 "description": "end-to-end browser test for chrome.experimental.mediaGalleries API",

	6 "background": {

	7 "page": "test.html"
	jstritar 2012/03/21 00:02:02 if you only have <script/>'s in test.html, you can if you only have <script/>'s in test.html, you can get rid of test.html and do this: "background": { "scripts": ["test.js"] } vandebo (ex-Chrome) 2012/03/21 16:17:57 I tried to do this, but it didn't work. Show quoted text On 2012/03/21 00:02:02, jstritar wrote: > if you only have <script/>'s in test.html, you can get rid of test.html and do > this: > > "background": { > "scripts": ["test.js"] > } I tried to do this, but it didn't work. jstritar 2012/03/21 18:10:47 What didn't work about it? Show quoted text On 2012/03/21 16:17:57, vandebo wrote: > > I tried to do this, but it didn't work. What didn't work about it? vandebo (ex-Chrome) 2012/03/21 22:08:07 [3608:3608:0321/143215:443953231440:ERROR:extensio Show quoted text On 2012/03/21 18:10:47, jstritar wrote: > On 2012/03/21 16:17:57, vandebo wrote: > > > > I tried to do this, but it didn't work. > > What didn't work about it? [3608:3608:0321/143215:443953231440:ERROR:extension_error_reporter.cc(56)] Extension error: Could not load extension from '/usr/local/google/home/vandebo/chrome/src/chrome/test/data/extensions/api_test/media_gallery'. Invalid value for 'background.scripts'. I looked closer and I wasn't putting the value in an array - I had "scripts": "test.js". An opportunity for improvement? Fixed.
	8 },

	9 "permissions": ["experimental"]

	10 }

OLD	NEW