Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: chrome/test/ui/npapi_uitest.cc

Issue 9358065: Flakiness cleanup: disable flaky tests under chrome/test/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/ui/layout_plugin_uitest.cc ('k') | chrome/test/ui/ppapi_uitest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <comutil.h> 8 #include <comutil.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #include <shlobj.h> 10 #include <shlobj.h>
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 // works properly when the plugin is embedded in a subframe. 97 // works properly when the plugin is embedded in a subframe.
98 TEST_F(NPAPITesterBase, GetJavaScriptURL2) { 98 TEST_F(NPAPITesterBase, GetJavaScriptURL2) {
99 const FilePath test_case(FILE_PATH_LITERAL("get_javascript_url2.html")); 99 const FilePath test_case(FILE_PATH_LITERAL("get_javascript_url2.html"));
100 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 100 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
101 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 101 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
102 WaitForFinish("getjavascripturl2", "1", url, kTestCompleteCookie, 102 WaitForFinish("getjavascripturl2", "1", url, kTestCompleteCookie,
103 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); 103 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms());
104 } 104 }
105 105
106 // Test is flaky on linux/cros/win builders. http://crbug.com/71904 106 // Test is flaky on linux/cros/win builders. http://crbug.com/71904
107 TEST_F(NPAPITesterBase, FLAKY_GetURLRedirectNotification) { 107 TEST_F(NPAPITesterBase, DISABLED_GetURLRedirectNotification) {
108 const FilePath test_case(FILE_PATH_LITERAL("geturl_redirect_notify.html")); 108 const FilePath test_case(FILE_PATH_LITERAL("geturl_redirect_notify.html"));
109 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 109 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
110 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 110 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
111 WaitForFinish("geturlredirectnotify", "1", url, kTestCompleteCookie, 111 WaitForFinish("geturlredirectnotify", "1", url, kTestCompleteCookie,
112 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); 112 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms());
113 } 113 }
114 114
115 // Tests that identity is preserved for NPObjects passed from a plugin 115 // Tests that identity is preserved for NPObjects passed from a plugin
116 // into JavaScript. 116 // into JavaScript.
117 TEST_F(NPAPITesterBase, NPObjectIdentity) { 117 TEST_F(NPAPITesterBase, NPObjectIdentity) {
(...skipping 13 matching lines...) Expand all
131 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 131 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
132 WaitForFinish("npobject_proxy", "1", url, kTestCompleteCookie, 132 WaitForFinish("npobject_proxy", "1", url, kTestCompleteCookie,
133 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); 133 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms());
134 } 134 }
135 135
136 #if defined(OS_WIN) || defined(OS_MACOSX) 136 #if defined(OS_WIN) || defined(OS_MACOSX)
137 // Tests if a plugin executing a self deleting script in the context of 137 // Tests if a plugin executing a self deleting script in the context of
138 // a synchronous paint event works correctly 138 // a synchronous paint event works correctly
139 // http://crbug.com/44960 139 // http://crbug.com/44960
140 TEST_F(NPAPIVisiblePluginTester, 140 TEST_F(NPAPIVisiblePluginTester,
141 FLAKY_SelfDeletePluginInvokeInSynchronousPaint) { 141 DISABLED_SelfDeletePluginInvokeInSynchronousPaint) {
142 show_window_ = true; 142 show_window_ = true;
143 const FilePath test_case( 143 const FilePath test_case(
144 FILE_PATH_LITERAL("execute_script_delete_in_paint.html")); 144 FILE_PATH_LITERAL("execute_script_delete_in_paint.html"));
145 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 145 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
146 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 146 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
147 WaitForFinish("execute_script_delete_in_paint", "1", url, 147 WaitForFinish("execute_script_delete_in_paint", "1", url,
148 kTestCompleteCookie, kTestCompleteSuccess, 148 kTestCompleteCookie, kTestCompleteSuccess,
149 TestTimeouts::action_max_timeout_ms()); 149 TestTimeouts::action_max_timeout_ms());
150 } 150 }
151 #endif 151 #endif
152 152
153 TEST_F(NPAPIVisiblePluginTester, SelfDeletePluginInNewStream) { 153 TEST_F(NPAPIVisiblePluginTester, SelfDeletePluginInNewStream) {
154 show_window_ = true; 154 show_window_ = true;
155 const FilePath test_case(FILE_PATH_LITERAL("self_delete_plugin_stream.html")); 155 const FilePath test_case(FILE_PATH_LITERAL("self_delete_plugin_stream.html"));
156 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 156 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
157 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 157 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
158 WaitForFinish("self_delete_plugin_stream", "1", url, 158 WaitForFinish("self_delete_plugin_stream", "1", url,
159 kTestCompleteCookie, kTestCompleteSuccess, 159 kTestCompleteCookie, kTestCompleteSuccess,
160 TestTimeouts::action_max_timeout_ms()); 160 TestTimeouts::action_max_timeout_ms());
161 } 161 }
162 162
163 // http://crbug.com/95558 163 // http://crbug.com/95558
164 // This test fails frequently on Mac and windows, so it is disabled for now. 164 // This test fails frequently on Mac and windows, so it is disabled for now.
165 #if defined(OS_MACOSX) 165 #if defined(OS_MACOSX)
166 #define MAYBE_DeletePluginInDeallocate DISABLED_DeletePluginInDeallocate 166 #define MAYBE_DeletePluginInDeallocate DISABLED_DeletePluginInDeallocate
167 #elif defined(OS_WIN) 167 #elif defined(OS_WIN)
168 #define MAYBE_DeletePluginInDeallocate FLAKY_DeletePluginInDeallocate 168 #define MAYBE_DeletePluginInDeallocate DISABLED_DeletePluginInDeallocate
169 #else 169 #else
170 #define MAYBE_DeletePluginInDeallocate DeletePluginInDeallocate 170 #define MAYBE_DeletePluginInDeallocate DeletePluginInDeallocate
171 #endif 171 #endif
172 TEST_F(NPAPIVisiblePluginTester, MAYBE_DeletePluginInDeallocate) { 172 TEST_F(NPAPIVisiblePluginTester, MAYBE_DeletePluginInDeallocate) {
173 show_window_ = true; 173 show_window_ = true;
174 const FilePath test_case( 174 const FilePath test_case(
175 FILE_PATH_LITERAL("plugin_delete_in_deallocate.html")); 175 FILE_PATH_LITERAL("plugin_delete_in_deallocate.html"));
176 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 176 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
177 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 177 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
178 WaitForFinish("delete_plugin_in_deallocate_test", "signaller", url, 178 WaitForFinish("delete_plugin_in_deallocate_test", "signaller", url,
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 } 267 }
268 268
269 #endif 269 #endif
270 270
271 // http://crbug.com/17645 271 // http://crbug.com/17645
272 // As of 6 July 2011, this test always fails on OS X and is flaky on 272 // As of 6 July 2011, this test always fails on OS X and is flaky on
273 // Windows (perhaps due to timing out). 273 // Windows (perhaps due to timing out).
274 #if defined(OS_MACOSX) 274 #if defined(OS_MACOSX)
275 #define MAYBE_OpenPopupWindowWithPlugin DISABLED_OpenPopupWindowWithPlugin 275 #define MAYBE_OpenPopupWindowWithPlugin DISABLED_OpenPopupWindowWithPlugin
276 #else 276 #else
277 #define MAYBE_OpenPopupWindowWithPlugin FLAKY_OpenPopupWindowWithPlugin 277 #define MAYBE_OpenPopupWindowWithPlugin DISABLED_OpenPopupWindowWithPlugin
278 #endif 278 #endif
279 279
280 TEST_F(NPAPIVisiblePluginTester, MAYBE_OpenPopupWindowWithPlugin) { 280 TEST_F(NPAPIVisiblePluginTester, MAYBE_OpenPopupWindowWithPlugin) {
281 const FilePath test_case( 281 const FilePath test_case(
282 FILE_PATH_LITERAL("get_javascript_open_popup_with_plugin.html")); 282 FILE_PATH_LITERAL("get_javascript_open_popup_with_plugin.html"));
283 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 283 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
284 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 284 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
285 WaitForFinish("plugin_popup_with_plugin_target", "1", url, 285 WaitForFinish("plugin_popup_with_plugin_target", "1", url,
286 kTestCompleteCookie, kTestCompleteSuccess, 286 kTestCompleteCookie, kTestCompleteSuccess,
287 TestTimeouts::action_timeout_ms()); 287 TestTimeouts::action_timeout_ms());
(...skipping 20 matching lines...) Expand all
308 const FilePath test_case(FILE_PATH_LITERAL("plugin_thread_async_call.html")); 308 const FilePath test_case(FILE_PATH_LITERAL("plugin_thread_async_call.html"));
309 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 309 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
310 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 310 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
311 WaitForFinish("plugin_thread_async_call", "1", url, kTestCompleteCookie, 311 WaitForFinish("plugin_thread_async_call", "1", url, kTestCompleteCookie,
312 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); 312 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms());
313 } 313 }
314 314
315 // Test checking the privacy mode is on. 315 // Test checking the privacy mode is on.
316 #if defined(OS_LINUX) 316 #if defined(OS_LINUX)
317 // http://crbug.com/104380 317 // http://crbug.com/104380
318 #define PrivateEnabled FLAKY_PrivateEnabled 318 #define PrivateEnabled DISABLED_PrivateEnabled
319 #endif 319 #endif
320 TEST_F(NPAPIIncognitoTester, PrivateEnabled) { 320 TEST_F(NPAPIIncognitoTester, PrivateEnabled) {
321 const FilePath test_case(FILE_PATH_LITERAL("private.html")); 321 const FilePath test_case(FILE_PATH_LITERAL("private.html"));
322 GURL url = ui_test_utils::GetFileUrlWithQuery( 322 GURL url = ui_test_utils::GetFileUrlWithQuery(
323 ui_test_utils::GetTestFilePath(FilePath(kTestDir), test_case), "private"); 323 ui_test_utils::GetTestFilePath(FilePath(kTestDir), test_case), "private");
324 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 324 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
325 WaitForFinish("private", "1", url, kTestCompleteCookie, 325 WaitForFinish("private", "1", url, kTestCompleteCookie,
326 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); 326 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms());
327 } 327 }
328 328
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 WaitForFinish("no_hang_if_init_crashes", "1", url, 377 WaitForFinish("no_hang_if_init_crashes", "1", url,
378 kTestCompleteCookie, kTestCompleteSuccess, 378 kTestCompleteCookie, kTestCompleteSuccess,
379 TestTimeouts::action_max_timeout_ms()); 379 TestTimeouts::action_max_timeout_ms());
380 CloseHandle(crash_event); 380 CloseHandle(crash_event);
381 } 381 }
382 382
383 #endif 383 #endif
384 384
385 #if defined(OS_MACOSX) 385 #if defined(OS_MACOSX)
386 // http://crbug.com/111508 386 // http://crbug.com/111508
387 #define PluginReferrerTest FLAKY_PluginReferrerTest 387 #define PluginReferrerTest DISABLED_PluginReferrerTest
388 #endif 388 #endif
389 TEST_F(NPAPIVisiblePluginTester, PluginReferrerTest) { 389 TEST_F(NPAPIVisiblePluginTester, PluginReferrerTest) {
390 GURL url(URLRequestMockHTTPJob::GetMockUrl( 390 GURL url(URLRequestMockHTTPJob::GetMockUrl(
391 FilePath(FILE_PATH_LITERAL( 391 FilePath(FILE_PATH_LITERAL(
392 "npapi/plugin_url_request_referrer_test.html")))); 392 "npapi/plugin_url_request_referrer_test.html"))));
393 393
394 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 394 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
395 395
396 WaitForFinish("plugin_referrer_test", "1", url, kTestCompleteCookie, 396 WaitForFinish("plugin_referrer_test", "1", url, kTestCompleteCookie,
397 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); 397 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms());
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 ASSERT_TRUE(tab->LoadBlockedPlugins()); 452 ASSERT_TRUE(tab->LoadBlockedPlugins());
453 453
454 WaitForFinish("setup", "1", url, kTestCompleteCookie, 454 WaitForFinish("setup", "1", url, kTestCompleteCookie,
455 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); 455 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms());
456 456
457 ASSERT_TRUE(tab->ExecuteJavaScript("window.inject()")); 457 ASSERT_TRUE(tab->ExecuteJavaScript("window.inject()"));
458 458
459 WaitForFinish("setup", "2", url, kTestCompleteCookie, 459 WaitForFinish("setup", "2", url, kTestCompleteCookie,
460 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms()); 460 kTestCompleteSuccess, TestTimeouts::action_max_timeout_ms());
461 } 461 }
OLDNEW
« no previous file with comments | « chrome/test/ui/layout_plugin_uitest.cc ('k') | chrome/test/ui/ppapi_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698