Flakiness cleanup: disable flaky tests under chrome/test/

chrome/test/automation/automation_proxy_uitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 395 matching lines @@
   ASSERT_TRUE(window->GetActiveTabIndex(&active_tab_index));
   ASSERT_EQ(0, active_tab_index);
 
   ASSERT_TRUE(window->ActivateTab(1));
   ASSERT_TRUE(window->GetActiveTabIndex(&active_tab_index));
   ASSERT_EQ(1, active_tab_index);
 }
 
 // http://crbug.com/98071
 #if defined(OS_MACOSX)
-#define MAYBE_GetTabTitle FLAKY_GetTabTitle
+#define MAYBE_GetTabTitle DISABLED_GetTabTitle
 #else
 #define MAYBE_GetTabTitle GetTabTitle
 #endif
 TEST_F(AutomationProxyTest2, MAYBE_GetTabTitle) {
   scoped_refptr<BrowserProxy> window(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(window.get());
   scoped_refptr<TabProxy> tab(window->GetTab(0));
   ASSERT_TRUE(tab.get());
   std::wstring title;
   ASSERT_TRUE(tab->GetTabTitle(&title));
@@ skipping 82 matching lines @@
   ASSERT_TRUE(window.get());
 
   ASSERT_TRUE(window->RunCommand(IDC_SHOW_DOWNLOADS));
 
   // We expect the RunCommand above to wait until the title is updated.
   EXPECT_EQ(L"Downloads", GetActiveTabTitle());
 }
 
 // http://crbug.com/109642
 #if defined(OS_MACOSX)
-#define MAYBE_AcceleratorExtensions FLAKY_AcceleratorExtensions
+#define MAYBE_AcceleratorExtensions DISABLED_AcceleratorExtensions
 #else
 #define MAYBE_AcceleratorExtensions AcceleratorExtensions
 #endif
 TEST_F(AutomationProxyTest, MAYBE_AcceleratorExtensions) {
   scoped_refptr<BrowserProxy> window(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(window.get());
 
   ASSERT_TRUE(window->RunCommand(IDC_MANAGE_EXTENSIONS));
 
   EXPECT_EQ("chrome://settings/extensions", GetActiveTabURL().spec());
@@ skipping 120 matching lines @@
   ASSERT_TRUE(tab->ExecuteAndExtractString(xpath2, jscript2, &actual));
   ASSERT_EQ(L"SPAN", actual);
 
   std::wstring xpath3 = L"/html/body/iframe\n/html/body/iframe";
   std::wstring jscript3 = CreateJSStringForDOMQuery(L"mydiv");
   ASSERT_TRUE(tab->ExecuteAndExtractString(xpath3, jscript3, &actual));
   ASSERT_EQ(L"DIV", actual);
 }
 
 // Flaky, http://crbug.com/70937
-TEST_F(AutomationProxyTest, FLAKY_BlockedPopupTest) {
+TEST_F(AutomationProxyTest, DISABLED_BlockedPopupTest) {
   scoped_refptr<BrowserProxy> window(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(window.get());
 
   scoped_refptr<TabProxy> tab(window->GetTab(0));
   ASSERT_TRUE(tab.get());
 
   FilePath filename(test_data_directory_);
   filename = filename.AppendASCII("constrained_files");
   filename = filename.AppendASCII("constrained_window.html");
 
@@ skipping 241 matching lines @@
 
 ExternalTabUITest::ExternalTabUITest() : UITest(MessageLoop::TYPE_UI) {}
 
 // Replace the default automation proxy with our mock client.
 ProxyLauncher* ExternalTabUITest::CreateProxyLauncher() {
   return new ExternalTabUITestMockLauncher(&mock_);
 }
 
 // Create with specifying a url
 // Flaky, http://crbug.com/32293
-TEST_F(ExternalTabUITest, FLAKY_CreateExternalTab1) {
+TEST_F(ExternalTabUITest, DISABLED_CreateExternalTab1) {
   scoped_refptr<TabProxy> tab;
   TimedMessageLoopRunner loop(MessageLoop::current());
   ASSERT_THAT(mock_, testing::NotNull());
 
   EXPECT_CALL(*mock_, OnNavigationStateChanged(_, _))
       .Times(testing::AnyNumber());
 
   EXPECT_CALL(*mock_, OnDidNavigate(testing::_))
       .Times(1)
       .WillOnce(testing::InvokeWithoutArgs(mock_,
                 &ExternalTabUITestMockClient::DestroyHostWindow));
 
   EXPECT_CALL(*mock_, HandleClosed(1))
       .Times(1)
       .WillOnce(QUIT_LOOP(&loop));
 
   tab = mock_->CreateTabWithUrl(GURL(simple_data_url));
   loop.RunFor(TestTimeouts::action_max_timeout_ms());
 }
 
 // Create with empty url and then navigate
 // Flaky, http://crbug.com/32293
-TEST_F(ExternalTabUITest, FLAKY_CreateExternalTab2) {
+TEST_F(ExternalTabUITest, DISABLED_CreateExternalTab2) {
   scoped_refptr<TabProxy> tab;
   TimedMessageLoopRunner loop(MessageLoop::current());
   ASSERT_THAT(mock_, testing::NotNull());
 
   EXPECT_CALL(*mock_, OnNavigationStateChanged(_, _))
       .Times(testing::AnyNumber());
 
   EXPECT_CALL(*mock_, OnDidNavigate(testing::_))
     .Times(1)
     .WillOnce(testing::InvokeWithoutArgs(mock_,
               &ExternalTabUITestMockClient::DestroyHostWindow));
 
   EXPECT_CALL(*mock_, HandleClosed(1))
     .Times(1)
     .WillOnce(QUIT_LOOP(&loop));
 
   tab = mock_->CreateTabWithUrl(GURL());
   mock_->NavigateInExternalTab(tab->handle(), GURL(simple_data_url));
   loop.RunFor(TestTimeouts::action_max_timeout_ms());
 }
 
 // FLAKY: http://crbug.com/60409
-TEST_F(ExternalTabUITest, FLAKY_IncognitoMode) {
+TEST_F(ExternalTabUITest, DISABLED_IncognitoMode) {
   scoped_refptr<TabProxy> tab;
   TimedMessageLoopRunner loop(MessageLoop::current());
   ASSERT_THAT(mock_, testing::NotNull());
 
   GURL url("http://anatomyofmelancholy.net");
   std::string cookie = "robert=burton; expires=Thu, 13 Oct 2011 05:04:03 UTC;";
 
   EXPECT_CALL(*mock_, HandleClosed(1)).Times(1);
 
   ExternalTabSettings incognito =
@@ skipping 21 matching lines @@
   tab = mock_->CreateTabWithUrl(GURL());
   EXPECT_TRUE(tab->GetCookieByName(url, "robert", &value_result));
   EXPECT_EQ("", value_result);
   EXPECT_CALL(*mock_, HandleClosed(1)).Times(1);
   mock_->DestroyHostWindow();
   CloseBrowserAndServer();
   tab = NULL;
 }
 
 // FLAKY: http://crbug.com/44617
-TEST_F(ExternalTabUITest, FLAKY_TabPostMessage) {
+TEST_F(ExternalTabUITest, DISABLED_TabPostMessage) {
   scoped_refptr<TabProxy> tab;
   TimedMessageLoopRunner loop(MessageLoop::current());
   ASSERT_THAT(mock_, testing::NotNull());
 
   EXPECT_CALL(*mock_, OnNavigationStateChanged(_, _))
       .Times(testing::AnyNumber());
   EXPECT_CALL(*mock_, OnLoad(_)).Times(testing::AnyNumber());
 
   std::string content =
       "data:text/html,<html><head><script>"
@@ skipping 23 matching lines @@
               &ExternalTabUITestMockClient::DestroyHostWindow)),
           QUIT_LOOP_SOON(&loop, 50)));
 
   EXPECT_CALL(*mock_, HandleClosed(1)).Times(1);
 
   tab = mock_->CreateTabWithUrl(GURL(content));
   loop.RunFor(TestTimeouts::action_max_timeout_ms());
 }
 
 // Flaky: http://crbug.com/62143
-TEST_F(ExternalTabUITest, FLAKY_PostMessageTarget)  {
+TEST_F(ExternalTabUITest, DISABLED_PostMessageTarget)  {
   net::TestServer test_server(
       net::TestServer::TYPE_HTTP,
       FilePath(FILE_PATH_LITERAL("chrome/test/data/external_tab")));
   ASSERT_TRUE(test_server.Start());
 
   scoped_refptr<TabProxy> tab;
   TimedMessageLoopRunner loop(MessageLoop::current());
   ASSERT_THAT(mock_, testing::NotNull());
   EXPECT_CALL(*mock_, OnNavigationStateChanged(_, _))
       .Times(testing::AnyNumber());
@@ skipping 328 matching lines @@
   mock_->CreateTabWithUrl(main_url);
   loop.RunFor(TestTimeouts::action_max_timeout_ms());
 
   EXPECT_CALL(*mock_, HandleClosed(1));
   ::DestroyWindow(foo_host);
   mock_->DestroyHostWindow();
 }
 #endif  // defined(OS_WIN)
 
 // Flaky especially on Windows. See crbug.com/25039.
-TEST_F(AutomationProxyTest, FLAKY_AppModalDialogTest) {
+TEST_F(AutomationProxyTest, DISABLED_AppModalDialogTest) {
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());
   scoped_refptr<TabProxy> tab(browser->GetTab(0));
   ASSERT_TRUE(tab.get());
 
   bool modal_dialog_showing = false;
   ui::DialogButton button = ui::DIALOG_BUTTON_NONE;
   EXPECT_TRUE(automation()->GetShowingAppModalDialog(&modal_dialog_showing,
                                                      &button));
   EXPECT_FALSE(modal_dialog_showing);
@@ skipping 166 matching lines @@
 
   std::string data;
   ASSERT_NO_FATAL_FAILURE(AssertReadPNG(snapshot_path_, &data));
   EXPECT_STREQ(kReferenceMd5, base::MD5String(data).c_str());
   if (CommandLine::ForCurrentProcess()->HasSwitch("dump-test-image")) {
     FilePath path(FILE_PATH_LITERAL("snapshot.png"));
     EXPECT_EQ(file_util::WriteFile(path, &data[0], data.length()),
               static_cast<int>(data.length()));
   }
 }