Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/browser/browsing_data_remover.cc

Issue 9358050: BrowsingDataRemover: Enable origin-based deletion for quota-managed data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data_remover.cc b/chrome/browser/browsing_data_remover.cc
index 1514f7ac708ab8865b3a9c8519835c626104ee37..49cfbc5badb93c448066d0cbf30635ec0c71b4cf 100644
--- a/chrome/browser/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data_remover.cc
@@ -289,9 +289,6 @@ void BrowsingDataRemover::RemoveImpl(int remove_mask,
if (remove_mask & REMOVE_INDEXEDDB || remove_mask & REMOVE_WEBSQL ||
remove_mask & REMOVE_APPCACHE || remove_mask & REMOVE_FILE_SYSTEMS) {
- // TODO(mkwst): At the moment, we don't have the ability to pass a mask into
- // QuotaManager. Until then, we'll clear all quota-managed data types if any
- // ought to be cleared.
quota_manager_ = profile_->GetQuotaManager();
if (quota_manager_) {
waiting_for_clear_quota_managed_data_ = true;
@@ -595,6 +592,8 @@ void BrowsingDataRemover::OnGotQuotaManagedOrigins(
for (origin = origins.begin(); origin != origins.end(); ++origin) {
if (special_storage_policy_->IsStorageProtected(origin->GetOrigin()))
continue;
+ if (!remove_origin_.is_empty() && remove_origin_ != origin->GetOrigin())
+ continue;
++quota_managed_origins_to_delete_count_;
quota_manager_->DeleteOriginData(
origin->GetOrigin(), type,
« no previous file with comments | « no previous file | chrome/browser/browsing_data_remover_unittest.cc » ('j') | chrome/browser/browsing_data_remover_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698