Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 9358001: Enable building with a small set of JNI related files required for linking content_unittests. (Closed)

Created:
8 years, 10 months ago by Satish
Modified:
8 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, John Grabowski, Yaron, michaelbai
Visibility:
Public.

Description

Enable building with a small set of JNI related files required for linking content_unittests. These are necessary for future CLs such as http://codereview.chromium.org/9264014/ BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M base/base.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M base/test/test_stub_android.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Satish
8 years, 10 months ago (2012-02-07 22:26:26 UTC) #1
brettw
lgtm
8 years, 10 months ago (2012-02-08 05:19:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/9358001/1
8 years, 10 months ago (2012-02-08 07:02:04 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 10 months ago (2012-02-08 08:07:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/9358001/1
8 years, 10 months ago (2012-02-08 08:34:39 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 10 months ago (2012-02-08 09:37:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/9358001/1
8 years, 10 months ago (2012-02-08 12:04:35 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 10 months ago (2012-02-08 13:08:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/9358001/1
8 years, 10 months ago (2012-02-08 14:11:19 UTC) #9
commit-bot: I haz the power
Try job failure for 9358001-1 (previous was lost) (retry) on win_rel for step "compile" (clobber ...
8 years, 10 months ago (2012-02-08 14:58:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/9358001/1
8 years, 10 months ago (2012-02-08 15:42:36 UTC) #11
commit-bot: I haz the power
Try job failure for 9358001-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 10 months ago (2012-02-08 16:15:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satish@chromium.org/9358001/1
8 years, 10 months ago (2012-02-08 20:09:53 UTC) #13
commit-bot: I haz the power
8 years, 10 months ago (2012-02-08 23:57:43 UTC) #14
Change committed as 121093

Powered by Google App Engine
This is Rietveld 408576698