Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 9355059: Renaming virtual setters/getters in UserManager. (Closed)

Created:
8 years, 10 months ago by Nikita (slow)
Modified:
8 years, 9 months ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews, nkostylev+watch_chromium.org, achuith+watch_chromium.org, kkania, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, robertshield, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Renaming virtual setters/getters in UserManager. Follow up CL for http://codereview.chromium.org/9348022/ * Renamed unix_hacker to CamelStyle methods from UserManager as they are not non-virtual getters and setters any more. - user_is_logged_in() - logged_in_user() - current_user_is_owner() / set_current_user_is_owner() - current_user_is_new() - downloaded_profile_image() BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125230

Patch Set 1 #

Patch Set 2 : more renaming #

Patch Set 3 : merge #

Patch Set 4 : merge with refactoring #

Patch Set 5 : year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -168 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers_chromeos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/choose_mobile_network_dialog.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cert_library.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/native_network_parser.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/onc_network_parser.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/device_settings_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/locale_change_guard.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/mock_user_manager.h View 1 2 3 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ownership_status_checker.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_screen.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 1 2 3 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.h View 1 2 3 4 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 2 3 12 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/power_button_observer.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/sim_dialog_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/screenshot_taker.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/status_area_host_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/status_area_host_aura_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/about_page_handler.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 2 3 4 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler2.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/accounts_options_handler2.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
chrome/browser/ui/webui/policy_ui.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
Please take a look. This CL only contains mass rename. I'll merge with http://codereview.chromium.org/9348022/ once ...
8 years, 10 months ago (2012-02-21 10:53:09 UTC) #1
Nikita (slow)
Trybots: http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds/890 http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos_clang/builds/148
8 years, 10 months ago (2012-02-21 11:37:23 UTC) #2
Ivan Korotkov
LGTM with: *) LoggedInUser should be GetLoggedInUser (otherwise it contains no verb). *) IsUserLoggedIn/IsCurrentUserOwner is ...
8 years, 10 months ago (2012-02-21 16:55:13 UTC) #3
Nikita (slow)
8 years, 10 months ago (2012-02-22 10:47:25 UTC) #4
On 2012/02/21 16:55:13, Ivan Korotkov wrote:
> LGTM with: 
> *) LoggedInUser should be GetLoggedInUser (otherwise it contains no verb).
> *) IsUserLoggedIn/IsCurrentUserOwner is preferred to UserIsLoggedIn, etc.

I'll update these and commit this CL after
http://codereview.chromium.org/9348022/ is committed.

Powered by Google App Engine
This is Rietveld 408576698