chrome/browser/policy/app_pack_updater.h - Issue 9355044: Added KioskModeAppPack proto.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/policy/app_pack_updater.h

Issue 9355044: Added KioskModeAppPack proto. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed unused forward declaration Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/chromeos/device_settings_provider.cc ('k') | chrome/browser/policy/app_pack_updater.cc » ('j') | chrome/browser/policy/proto/chrome_device_policy.proto » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_POLICY_APP_PACK_UPDATER_H_

	6 #define CHROME_BROWSER_POLICY_APP_PACK_UPDATER_H_

	7 #pragma once

	8

	9 namespace policy {

	10

	11 // Work in progress: http://crosbug.com/25463

	12 class AppPackUpdater {
	pastarmovj 2012/02/21 14:06:40 I guess this class is going to grow beyond a conta I guess this class is going to grow beyond a container for three constants right? If so I am fine with how you have it now. If not I guess a namespace would be better. Btw this is a rather vague memory but I think there was some issues with static members and inheritance over lib boundaries. Could that impact mock-ability of this class? What speaks against having those as a global constants in the policy namespace possible renamed s/^k/kAppPack/. Joao da Silva 2012/02/21 15:24:49 It a big class :-) This is the bare minimum for th Show quoted text On 2012/02/21 14:06:40, pastarmovj wrote: > I guess this class is going to grow beyond a container for three constants > right? If so I am fine with how you have it now. If not I guess a namespace > would be better. It a big class :-) This is the bare minimum for this CL, since the field names are required to decode the message. Show quoted text > > Btw this is a rather vague memory but I think there was some issues with static > members and inheritance over lib boundaries. Could that impact mock-ability of > this class? What speaks against having those as a global constants in the policy > namespace possible renamed s/^k/kAppPack/. I don't expect these constants to be used out of libbrowser, and I also don't think they matter to mocking. I've scoped them within the class to avoid polluting the policy namespace, and to signal that these are AppPack-related constants. Having an kAppPack prefix in the policy namespace would also work.
	13 public:

	14 // Keys for the entries in the KioskModeAppPack dictionary policy.

	15 static const char kExtensionId[];

	16 static const char kUpdateUrl[];

	17 static const char kKeyChecksum[];

	18 };

	19

	20 } // namespace policy

	21

	22 #endif // CHROME_BROWSER_POLICY_APP_PACK_UPDATER_H_

OLD	NEW