Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 9355020: Added framework for canvas benchmark and two examples that stress drawImage. One example draws mult… (Closed)

Created:
8 years, 10 months ago by alokp
Modified:
8 years, 10 months ago
Reviewers:
jbates
CC:
chromium-reviews
Visibility:
Public.

Description

Added framework for canvas benchmark and two examples that stress drawImage. One example draws multiple instances of a single image while the other draws multiple images. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122605

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+557 lines, -0 lines) Patch
A canvas_bench/bench.js View 1 chunk +29 lines, -0 lines 0 comments Download
A canvas_bench/many_images.html View 1 chunk +443 lines, -0 lines 0 comments Download
A canvas_bench/single_image.html View 1 chunk +44 lines, -0 lines 1 comment Download
A canvas_bench/sprites.js View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alokp
8 years, 10 months ago (2012-02-17 21:42:05 UTC) #1
Justin Novosad
On 2012/02/17 21:42:05, Alok Priyadarshi wrote: What is the added value of canvas_bench/single_image.html compared to ...
8 years, 10 months ago (2012-02-17 21:50:52 UTC) #2
alokp
On 2012/02/17 21:50:52, junov wrote: > On 2012/02/17 21:42:05, Alok Priyadarshi wrote: > > What ...
8 years, 10 months ago (2012-02-17 21:54:25 UTC) #3
jbates
lgtm http://codereview.chromium.org/9355020/diff/1/canvas_bench/single_image.html File canvas_bench/single_image.html (right): http://codereview.chromium.org/9355020/diff/1/canvas_bench/single_image.html#newcode39 canvas_bench/single_image.html:39: <canvas id="canvas" width="800" height = "600"> Do you ...
8 years, 10 months ago (2012-02-17 22:13:26 UTC) #4
alokp
On 2012/02/17 22:13:26, jbates wrote: > lgtm > > http://codereview.chromium.org/9355020/diff/1/canvas_bench/single_image.html > File canvas_bench/single_image.html (right): > ...
8 years, 10 months ago (2012-02-17 22:21:06 UTC) #5
jbates
8 years, 10 months ago (2012-02-17 22:22:44 UTC) #6
On 2012/02/17 22:21:06, Alok Priyadarshi wrote:
> On 2012/02/17 22:13:26, jbates wrote:
> > lgtm
> > 
> > http://codereview.chromium.org/9355020/diff/1/canvas_bench/single_image.html
> > File canvas_bench/single_image.html (right):
> > 
> >
>
http://codereview.chromium.org/9355020/diff/1/canvas_bench/single_image.html#...
> > canvas_bench/single_image.html:39: <canvas id="canvas" width="800" height =
> > "600">
> > Do you think the canvas sizes in these demos should match the window size?
> That
> > way we can control or vary the size via command-line (--window-size=w,h).
> 
> It has pros and cons. One downside I can think of is that it will be difficult
> to directly compare performance on different browsers.

Good point, better leave as is then.

Powered by Google App Engine
This is Rietveld 408576698