chrome/browser/ui/browser_browsertest.cc - Issue 9353010: Add FullscreenController::ToggleFullscreenModeWithExtension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 9353010: Add FullscreenController::ToggleFullscreenModeWithExtension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix copyright, compile erorr. Moved browser.h/cc change to this patch set. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index ebb7a88c7ade25ad9a332944ac182c2b01a0dc43..c55cff5add796d6cd9113295b4a8f0a7edf6738f 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -916,13 +916,13 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, TestFullscreenBubbleMouseLockState) {

browser()->RequestToLockMouse(fullscreen_tab);

FullscreenExitBubbleType type =

- browser()->fullscreen_controller_->GetFullscreenExitBubbleType();

+ browser()->fullscreen_controller_->GetFullscreenExitBubbleType(NULL);

bool mouse_lock = false;

fullscreen_bubble::PermissionRequestedByType(type, NULL, &mouse_lock);

ASSERT_TRUE(mouse_lock);

browser()->OnAcceptFullscreenPermission(fullscreen_tab->GetURL(), type);

- type = browser()->fullscreen_controller_->GetFullscreenExitBubbleType();

+ type = browser()->fullscreen_controller_->GetFullscreenExitBubbleType(NULL);

ASSERT_FALSE(fullscreen_bubble::ShowButtonsForType(type));

}

@@ -953,7 +953,7 @@ IN_PROC_BROWSER_TEST_F(

ui_test_utils::WindowedNotificationObserver fullscreen_observer(

chrome::NOTIFICATION_FULLSCREEN_CHANGED,

content::NotificationService::AllSources());

- browser()->TogglePresentationMode(false);

+ browser()->TogglePresentationMode();

fullscreen_observer.Wait();

ASSERT_FALSE(browser()->window()->IsFullscreen());

ASSERT_FALSE(browser()->window()->InPresentationMode());

@@ -965,7 +965,7 @@ IN_PROC_BROWSER_TEST_F(

ui_test_utils::WindowedNotificationObserver fullscreen_observer(

chrome::NOTIFICATION_FULLSCREEN_CHANGED,

content::NotificationService::AllSources());

- browser()->ToggleFullscreenMode(false);

+ browser()->ToggleFullscreenMode();

fullscreen_observer.Wait();

ASSERT_TRUE(browser()->window()->IsFullscreen());

ASSERT_FALSE(browser()->window()->InPresentationMode());