Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5862)

Unified Diff: chrome/browser/ui/browser.cc

Issue 9353010: Add FullscreenController::ToggleFullscreenModeWithExtension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Show "An extension triggered full screen." when the extension's name is not available. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index dfb836f77854e5647dd398b982345a351cf1a592..28306e3fb03fcf3f0203bcd5814538f9c10037bd 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -887,7 +887,7 @@ WebContents* Browser::OpenApplicationTab(Profile* profile,
// full screen mode in this case?
if (launch_type == ExtensionPrefs::LAUNCH_FULLSCREEN &&
!browser->window()->IsFullscreen()) {
- browser->ToggleFullscreenMode(false);
+ browser->ToggleFullscreenMode();
}
return contents;
@@ -1837,14 +1837,17 @@ void Browser::ConvertPopupToTabbedBrowser() {
browser->window()->Show();
}
-// TODO(koz): Change |for_tab| to an enum.
-void Browser::ToggleFullscreenMode(bool for_tab) {
- fullscreen_controller_->ToggleFullscreenMode(for_tab);
+void Browser::ToggleFullscreenMode() {
+ fullscreen_controller_->ToggleFullscreenMode();
+}
+
+void Browser::ToggleFullscreenModeWithExtension(const Extension& extension) {
+ fullscreen_controller_->ToggleFullscreenModeWithExtension(extension);
}
#if defined(OS_MACOSX)
-void Browser::TogglePresentationMode(bool for_tab) {
- fullscreen_controller_->TogglePresentationMode(for_tab);
+void Browser::TogglePresentationMode() {
+ fullscreen_controller_->TogglePresentationMode();
}
#endif
@@ -1852,7 +1855,7 @@ void Browser::TogglePresentationMode(bool for_tab) {
void Browser::Search() {
// Exit fullscreen to show omnibox.
if (window_->IsFullscreen()) {
- ToggleFullscreenMode(false);
+ ToggleFullscreenMode();
// ToggleFullscreenMode is asynchronous, so we don't have omnibox
// visible at this point. Wait for next event cycle which toggles
// the visibility of omnibox before creating new tab.
@@ -2950,9 +2953,9 @@ void Browser::ExecuteCommandWithDisposition(
case IDC_RESTORE_TAB: RestoreTab(); break;
case IDC_COPY_URL: WriteCurrentURLToClipboard(); break;
case IDC_SHOW_AS_TAB: ConvertPopupToTabbedBrowser(); break;
- case IDC_FULLSCREEN: ToggleFullscreenMode(false); break;
+ case IDC_FULLSCREEN: ToggleFullscreenMode(); break;
#if defined(OS_MACOSX)
- case IDC_PRESENTATION_MODE: TogglePresentationMode(false); break;
+ case IDC_PRESENTATION_MODE: TogglePresentationMode(); break;
#endif
case IDC_EXIT: Exit(); break;
#if defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698