Implement try/catch without finally, and without type checks.

frog/leg/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
 }
 
 class TreeElementMapping implements TreeElements {
@@ skipping 826 matching lines @@
 
   visitNamedArgument(NamedArgument node) {
     visit(node.expression);
   }
 
   visitSwitchStatement(SwitchStatement node) {
     compiler.unimplemented('switch', node: node);
   }
 
   visitTryStatement(TryStatement node) {
-    compiler.unimplemented('try', node: node);
+    visit(node.tryBlock);
+    if (node.catchBlocks.isEmpty() && node.finallyBlock == null) {
+      error(node, MessageKind.NO_CATCH_NOR_FINALLY);

[ahe, 2012/02/07 19:10:35]

The precise location here is:

node.getEndToken.next

[ngeoffray, 2012/02/08 09:52:23]

Added a TODO because there is no API for compiler where reportError takes a
token.

[ahe, 2012/02/08 10:19:27]

Please file a bug and assign it to me.

Cheers,
Peter

[ngeoffray, 2012/02/08 10:23:21]

Done: http://code.google.com/p/dart/issues/detail?id=1581

[ahe, 2012/02/08 10:27:12]

Thank you. I can see that you put the issue number in the TODO and this was
exactly what I hoped you'd do!

+    }
+    visit(node.catchBlocks);
+    visit(node.finallyBlock);
   }
 
   visitCatchBlock(CatchBlock node) {
-    compiler.unimplemented('catch', node: node);
+    Scope scope = new BlockScope(context);
+    if (node.formals.isEmpty()) {
+      error(node, MessageKind.EMPTY_CATCH_DECLARATION);
+    } else if (!node.formals.nodes.tail.isEmpty()
+               && !node.formals.nodes.tail.tail.isEmpty()) {
+      error(node.formals.nodes.tail.tail.head,

[ahe, 2012/02/07 19:10:35]

} else if (!node.formals.nodes.tail.isEmpty()) {
  for (Node extra in node.formals.nodes.tail.tail) {
   error(extra, ...)
  }

[ngeoffray, 2012/02/08 09:52:23]

Done.

+            MessageKind.TOO_MANY_CATCH_DECLARATIONS);
+    }
+    visitIn(node.formals, scope);
+    visitIn(node.block, scope);
   }
 
   visitTypedef(Typedef node) {
     compiler.unimplemented('typedef', node: node);
   }
 }
 
 class ClassResolverVisitor extends AbstractVisitor<Type> {
   Compiler compiler;
   Scope context;
@@ skipping 303 matching lines @@
 class TopScope extends Scope {
   LibraryElement get library() => element;
 
   TopScope(LibraryElement library) : super(null, library);
   Element lookup(SourceString name) => library.find(name);
 
   Element add(Element element) {
     throw "Cannot add an element in the top scope";
   }
 }