Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 9351010: views / Windows: A child window should be centered with respect to its parent, not the monitor. (Closed)

Created:
8 years, 10 months ago by Lei Zhang
Modified:
8 years, 10 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

views / Windows: A child window should be centered with respect to its parent, not the monitor. BUG=112614 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -51 lines) Patch
M ui/base/win/hwnd_util.h View 1 chunk +3 lines, -5 lines 0 comments Download
M ui/base/win/hwnd_util.cc View 3 chunks +30 lines, -45 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
I'm not sure if this is right, but it seems to work ok for me. ...
8 years, 10 months ago (2012-02-07 06:58:53 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 10 months ago (2012-02-07 20:22:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9351010/1
8 years, 10 months ago (2012-02-08 08:45:48 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 10 months ago (2012-02-08 09:48:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/9351010/1
8 years, 10 months ago (2012-02-09 02:12:41 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-09 03:56:33 UTC) #6
Change committed as 121180

Powered by Google App Engine
This is Rietveld 408576698