Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 9350052: Use 'readlink -f .' instead of 'pwd' when setting CHROME_SRC (Closed)

Created:
8 years, 10 months ago by Xianzhu
Modified:
8 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use 'readlink -f .' instead of 'pwd' when setting CHROME_SRC Some python script (e.g. tools/grit/grit/node/misc.py) assumes that there is no symblic link in the path of CHROME_SRC. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/envsetup.sh View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Xianzhu
8 years, 10 months ago (2012-02-13 21:24:19 UTC) #1
John Grabowski
LGTM There are other spots to fix this; while here can you scan build/android/* and ...
8 years, 10 months ago (2012-02-13 21:29:44 UTC) #2
Xianzhu
The others seem not causing problems. I'm thinking of keeping the $(pwd) (because it looks ...
8 years, 10 months ago (2012-02-13 22:06:22 UTC) #3
Xianzhu
Just tried to fix in grit/grit/node/misc.py, but other failure occurred. So I'd still use the ...
8 years, 10 months ago (2012-02-13 22:35:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/9350052/1
8 years, 10 months ago (2012-02-13 22:35:47 UTC) #5
commit-bot: I haz the power
8 years, 10 months ago (2012-02-14 00:42:02 UTC) #6
Change committed as 121788

Powered by Google App Engine
This is Rietveld 408576698