Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 9350051: Removing unneeded macro (Closed)

Created:
8 years, 10 months ago by dpapad
Modified:
8 years, 10 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, Lei Zhang
Visibility:
Public.

Description

Removing unneeded macro BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121801

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing commetns #

Total comments: 2

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M base/gtest_prod_util.h View 1 2 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/sticky_settings.h View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dpapad
8 years, 10 months ago (2012-02-13 21:21:03 UTC) #1
Lei Zhang
http://codereview.chromium.org/9350051/diff/1/base/gtest_prod_util.h File base/gtest_prod_util.h (right): http://codereview.chromium.org/9350051/diff/1/base/gtest_prod_util.h#newcode44 base/gtest_prod_util.h:44: // Use FORWARD_DECLARE_TEST_ALL_PREFIXES to do so for all possible ...
8 years, 10 months ago (2012-02-13 22:13:55 UTC) #2
dpapad
http://codereview.chromium.org/9350051/diff/1/base/gtest_prod_util.h File base/gtest_prod_util.h (right): http://codereview.chromium.org/9350051/diff/1/base/gtest_prod_util.h#newcode44 base/gtest_prod_util.h:44: // Use FORWARD_DECLARE_TEST_ALL_PREFIXES to do so for all possible ...
8 years, 10 months ago (2012-02-13 22:16:12 UTC) #3
dpapad
@brettw: Owners LGTM needed.
8 years, 10 months ago (2012-02-13 22:17:11 UTC) #4
brettw
lgtm http://codereview.chromium.org/9350051/diff/4001/base/gtest_prod_util.h File base/gtest_prod_util.h (right): http://codereview.chromium.org/9350051/diff/4001/base/gtest_prod_util.h#newcode64 base/gtest_prod_util.h:64: class test_case_name##_##test_name##_Test; \ Normally these would be indented ...
8 years, 10 months ago (2012-02-13 22:22:12 UTC) #5
dpapad
http://codereview.chromium.org/9350051/diff/4001/base/gtest_prod_util.h File base/gtest_prod_util.h (right): http://codereview.chromium.org/9350051/diff/4001/base/gtest_prod_util.h#newcode64 base/gtest_prod_util.h:64: class test_case_name##_##test_name##_Test; \ On 2012/02/13 22:22:12, brettw wrote: > ...
8 years, 10 months ago (2012-02-13 22:30:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpapad@chromium.org/9350051/1005
8 years, 10 months ago (2012-02-13 23:31:16 UTC) #7
commit-bot: I haz the power
Change committed as 121801
8 years, 10 months ago (2012-02-14 01:19:10 UTC) #8
Paweł Hajdan Jr.
8 years, 10 months ago (2012-02-14 08:53:14 UTC) #9
LGTM, thank you.

Powered by Google App Engine
This is Rietveld 408576698