Disable Chrome's print preview in Chrome Frame.

Disable Chrome's print preview in Chrome Frame.

BUG=95568
TEST=do something on a page that calls window.print(); expect IE's print dialog to appear.  should be covered by new test in chrome_frame_tests.exe.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121891

[robertshield, 2012-02-13 20:23:20]

lgtm

https://chromiumcodereview.appspot.com/9350044/diff/4002/chrome_frame/test/ui...
File chrome_frame/test/ui_test.cc (right):

https://chromiumcodereview.appspot.com/9350044/diff/4002/chrome_frame/test/ui...
chrome_frame/test/ui_test.cc:394: .WillOnce(WatchWindow(&win_observer_mock,
"Print", ""));
Does the print window contain the word "Print" on all versions of Windows?

[grt (UTC plus 2), 2012-02-14 01:48:30]

Thanks.

https://chromiumcodereview.appspot.com/9350044/diff/4002/chrome_frame/test/ui...
File chrome_frame/test/ui_test.cc (right):

https://chromiumcodereview.appspot.com/9350044/diff/4002/chrome_frame/test/ui...
chrome_frame/test/ui_test.cc:394: .WillOnce(WatchWindow(&win_observer_mock,
"Print", ""));
On 2012/02/13 20:23:21, robertshield wrote:
> Does the print window contain the word "Print" on all versions of Windows?

Your guess is as good as mine.  I think I have a few VMs that still work I can
try it on.  Alternatively, I could land it with a little extra logging and see
how it goes through the main builders.

[grt (UTC plus 2), 2012-02-14 03:47:54]

On 2012/02/14 01:48:30, grt wrote:
> Your guess is as good as mine.  I think I have a few VMs that still work I can
> try it on.  Alternatively, I could land it with a little extra logging and see
> how it goes through the main builders.

As far as I can tell, "Print" is the right thing for IE 6, 7, and 8.  Do you
have a machine with IE 9 on which you could Ctrl-P and check the window title
for me?

[robertshield, 2012-02-14 04:35:22]

Confirmed, the dialog in Win7/IE9 is titled Print as well. LGTM++

On Mon, Feb 13, 2012 at 10:47 PM, <grt@chromium.org> wrote:

> On 2012/02/14 01:48:30, grt wrote:
>
>> Your guess is as good as mine.  I think I have a few VMs that still work
>> I can
>> try it on.  Alternatively, I could land it with a little extra logging
>> and see
>> how it goes through the main builders.
>>
>
> As far as I can tell, "Print" is the right thing for IE 6, 7, and 8.  Do
> you
> have a machine with IE 9 on which you could Ctrl-P and check the window
> title
> for me?
>
>
https://chromiumcodereview.**appspot.com/9350044/<https://chromiumcodereview....
>

[commit-bot: I haz the power, 2012-02-14 14:56:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/9350044/4002

[commit-bot: I haz the power, 2012-02-14 16:21:34]

Change committed as 121891