Adding a trailing '/' to the doc switcher URL.

Adding a trailing '/' to the doc switcher URL.

BUG=112999
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120815

[Mike West, 2012-02-07 15:51:55]

Hey Aaron, I think the switcher has a tiny bug: it redirects to
http://code.google.com/chrome/extensions/beta. It should redirect to
http://code.google.com/chrome/extensions/beta/ (trailing slash).

Relatedly, would you have anything against swapping out the URL so that we do
our best to land the user on the same doc on a different branch?  That is,
redirecting from
http://code.google.com/chrome/extensions/trunk/experimental.html to
http://code.google.com/chrome/extensions/beta/experimental.html ?

[Aaron Boodman, 2012-02-07 19:07:33]

LGTM, your suggested improvement also sounds good to me if you have
time to impl.

- a

On Tue, Feb 7, 2012 at 7:51 AM,  <mkwst@chromium.org> wrote:
> Reviewers: Aaron Boodman,
>
> Message:
> Hey Aaron, I think the switcher has a tiny bug: it redirects to
> http://code.google.com/chrome/extensions/beta. It should redirect to
> http://code.google.com/chrome/extensions/beta/ (trailing slash).
>
> Relatedly, would you have anything against swapping out the URL so that we
> do
> our best to land the user on the same doc on a different branch?  That is,
> redirecting from
> http://code.google.com/chrome/extensions/trunk/experimental.html to
> http://code.google.com/chrome/extensions/beta/experimental.html ?
>
> Description:
> Adding a trailing '/' to the doc switcher URL.
>
> BUG=112999
> TEST=
>
>
> Please review this at http://codereview.chromium.org/9350019/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/common/extensions/docs/js/bootstrap.js
>
>
> Index: chrome/common/extensions/docs/js/bootstrap.js
> diff --git a/chrome/common/extensions/docs/js/bootstrap.js
> b/chrome/common/extensions/docs/js/bootstrap.js
> index
>
ef3b37fa790d86c008d6822eddfd089212953bb6..309e2413c0d5c51c53d1eb222daaff1cdd11de61
> 100644
> --- a/chrome/common/extensions/docs/js/bootstrap.js
> +++ b/chrome/common/extensions/docs/js/bootstrap.js
> @@ -76,7 +76,7 @@ if (window.location.search == "?regenerate" ||
>           currentBranch.toUpperCase();
>       document.getElementById('branchWarning').style.display = 'block';
>       document.getElementById('branchChooser').onchange = function() {
> -        location.href = officialURL + this.value;
> +        location.href = officialURL + this.value + "/";
>       };
>     }
>   }
>
>

[commit-bot: I haz the power, 2012-02-07 20:17:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/9350019/1

[commit-bot: I haz the power, 2012-02-07 20:17:23]

Presubmit check for 9350019-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.( \*/)?\n
Found a bad license header in these files:
  chrome/common/extensions/docs/js/bootstrap.js

[Mike West, 2012-02-07 20:17:51]

On 2012/02/07 19:07:33, Aaron Boodman wrote:
> LGTM, your suggested improvement also sounds good to me if you have
> time to impl.

Should be straightforward. I'll land this now just to fix the bug, and take a
look at the mapping tomorrow.