Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: net/base/file_stream.h

Issue 9349005: net: Rename FileStream::Open/Close with OpenSync/CloseSync. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win build Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/file_stream.h
diff --git a/net/base/file_stream.h b/net/base/file_stream.h
index a50d9c0ebfdde73a2fc4823c37586a7df2e7b036..39863a5362f2c61eb5f8a513ecf29b2cb2e4feb1 100644
--- a/net/base/file_stream.h
+++ b/net/base/file_stream.h
@@ -47,16 +47,20 @@ class NET_EXPORT FileStream {
virtual ~FileStream();
- // Call this method to close the FileStream. It is OK to call Close
- // multiple times. Redundant calls are ignored.
+ // Call this method to close the FileStream synchronously.
+ // It is OK to call Close multiple times. Redundant calls are ignored.
// Note that if there are any pending async operations, they'll be aborted.
- virtual void Close();
+ //
+ // TODO(satorux): Implement the asynchronous version of this.
+ virtual void CloseSync();
- // Call this method to open the FileStream. The remaining methods
- // cannot be used unless this method returns OK. If the file cannot be
- // opened then an error code is returned.
- // open_flags is a bitfield of base::PlatformFileFlags
- virtual int Open(const FilePath& path, int open_flags);
+ // Call this method to open the FileStream synchronously.
+ // The remaining methods cannot be used unless this method returns OK. If
+ // the file cannot be opened then an error code is returned. open_flags is
+ // a bitfield of base::PlatformFileFlags
+ //
+ // TODO(satorux): Implement the asynchronous version of this.
+ virtual int OpenSync(const FilePath& path, int open_flags);
// Returns true if Open succeeded and Close has not been called.
virtual bool IsOpen() const;

Powered by Google App Engine
This is Rietveld 408576698